Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly restore state of redirect #1639

Merged
merged 1 commit into from
May 29, 2024
Merged

Correctly restore state of redirect #1639

merged 1 commit into from
May 29, 2024

Conversation

OscarSpruit
Copy link
Contributor

Description

When the process died and state was restored it kept opening the redirect. Causing the user to be stuck in an indefinite redirect loop.

Checklist

  • PR is labelled
  • Code is unit tested
  • Changes are tested manually

COAND-857

@OscarSpruit OscarSpruit added the Chore [PRs only] Indicates any task that does not need to be mentioned in the public release notes label May 29, 2024
@OscarSpruit OscarSpruit requested a review from a team as a code owner May 29, 2024 09:50
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 29, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
6.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@OscarSpruit OscarSpruit merged commit 078cea1 into develop May 29, 2024
7 of 8 checks passed
@OscarSpruit OscarSpruit deleted the fix/redirect-state-restoration branch May 29, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@araratthehero araratthehero araratthehero approved these changes

Assignees
No one assigned
Labels
Chore [PRs only] Indicates any task that does not need to be mentioned in the public release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OscarSpruit @araratthehero