Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

French Meal Vouchers #1788

Merged
merged 44 commits into from
Oct 8, 2024
Merged

French Meal Vouchers #1788

merged 44 commits into from
Oct 8, 2024

Conversation

araratthehero
Copy link
Contributor

@araratthehero araratthehero commented Sep 9, 2024 •
edited by ozgur00
Loading

Description

Implementation of French meal vouchers.

The implementation extends the Giftcard logic, since French meal vouchers are handled like giftcards, with an additional field. To keep them separate, a new module has been created.

Pending

We are still waiting for test cards to finalize the testing of the integration.

Checklist

  • PR is labelled
  • Code is unit tested
  • Changes are tested manually

COAND-683

@araratthehero araratthehero added the Feature [PRs only] Indicates a new feature addition label Sep 9, 2024
@araratthehero araratthehero marked this pull request as ready for review September 10, 2024 09:02
@araratthehero araratthehero requested a review from a team as a code owner September 10, 2024 09:02
jreij
jreij reviewed Sep 10, 2024
View reviewed changes
meal-voucher-fr/src/main/java/com/adyen/checkout/mealvoucherfr/MealVoucherFRConfiguration.kt Outdated
Copy link
Collaborator

@jreij jreij Sep 10, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a method for this configuration inside DropInConfiguration.Builder

araratthehero and others added 22 commits October 8, 2024 10:39
@araratthehero @ozgur00
Create mealvoucher module
3375079 
COAND-683
@ozgur00
Create MealVoucher component related classes
7e341cd 
COAND-683
@ozgur00
Implement MealVoucherComponentProvider and MealVoucherComponent
7c74dac 
COAND-683
@ozgur00
Implement MealVoucherViewProvider
906fd4f 
COAND-683
@araratthehero @ozgur00
Move ExpiryDateInput and ExpiryDate to ui-core
f834d2d 
COAND-683
@araratthehero @ozgur00
Move SecurityCodeInput to ui-core and extend from AdyenTextInputEditT…
42ee825 
…ext instead of CardNumberInput

COAND-683
@araratthehero @ozgur00
Create meal voucher view
dbfacdb 
COAND-683
@araratthehero @ozgur00
Run apiDump
0a2d7ed 
COAND-683
@araratthehero @ozgur00
Create MealVoucherComponentParamsMapper and add isExpiryDateRequired …
7d41b16 
…field

COAND-683
@araratthehero @ozgur00
Add expiry date to DefaultGiftCardDelegate
5f700ef 
COAND-683
@ozgur00
Extract common expiry date validation logic to ui-core
1d74d0f 
COAND-683
@ozgur00
Implement expiry date validation and extract validation logic to Gift…
521f903 
…CardValidator

COAND-683
@araratthehero @ozgur00
Provide different messages for giftcard and meal voucher on card vali…
3d1aed3 
…dation

COAND-683
@araratthehero @ozgur00
Provide different messages for giftcard and meal voucher on pin valid…
8632217 
…ation

COAND-683
@ozgur00
Create GiftCardProtocol
00b4640 
GiftCardProtocol is used to make and get necessary details for different Gift Card flows such as gift cards and meal vouchers.

COAND-693
@ozgur00
Create GiftCardProtocol
60cf1c8 
GiftCardProtocol is used to make and get necessary details for different Gift Card flows such as gift cards and meal vouchers.

COAND-693
@araratthehero @ozgur00
Create meal voucher configuration
202d07b 
COAND-683
@araratthehero @ozgur00
Remove unnecessary payment method type
3b8788a 
COAND-683
@ozgur00
Create GiftCardProtocol
71ef9c9 
GiftCardProtocol is used to make and get necessary details for different Gift Card flows such as gift cards and meal vouchers.

COAND-693
@araratthehero @ozgur00
Change mealvoucher naming to meal_voucher
41d185b 
COAND-683
@araratthehero @ozgur00
Remove unnecessary MEAL_VOUCHER_FR from PaymentMethodTypes
9192085 
COAND-683
@araratthehero @ozgur00
Update class visibilities
9455030 
COAND-683
araratthehero and others added 14 commits October 8, 2024 10:39
@araratthehero @ozgur00
Write tests for GiftCardNumberUtils
baec23a 
COAND-683
@ozgur00
Add tests for ExpiryDateValidationUtils
48caad4 
COAND-693
@araratthehero @ozgur00
Add tests for CardValidationUtils
8ad43d8 
COAND-693
@araratthehero @ozgur00
Add tests for GiftCardPinUtils
f2306f1 
COAND-693
@araratthehero @ozgur00
Optimize CardValidationUtils and update unit tests
e54642a 
COAND-693
@ozgur00
Update meal voucher translations
aac2331 
COAND-693
@ozgur00
Update max digit limit for security code input
4c0ef51 
COAND-693
@ozgur00
Run apiDump
e64052a 
COAND-693
@ozgur00
Add meal voucher component, configuration and params mapper tests
985c07d 
COAND-693
@ozgur00
Fix remaining meal voucher todos
83f2cef 
COAND-693
@ozgur00
Rename meal-voucher module to meal-voucher-fr
0b9767f 
COAND-693
@araratthehero @ozgur00
Add release notes
a9dd250 
COAND-693
@araratthehero @ozgur00
Add meal voucher configuration in DropInConfiguration
1b39158 
COAND-693
@araratthehero @ozgur00
Restrict input edit texts
6025e8e 
COAND-693
@ozgur00 ozgur00 force-pushed the feature/french_meal_vouchers branch from 58a9da8 to eab8242 Compare October 8, 2024 08:40
jreij
jreij reviewed Oct 8, 2024
View reviewed changes
RELEASE_NOTES.md Outdated Show resolved Hide resolved
@ozgur00 ozgur00 force-pushed the feature/french_meal_vouchers branch from eab8242 to 0df176d Compare October 8, 2024 09:05
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 8, 2024

✅ No public API changes

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 8, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
75.1% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@araratthehero araratthehero merged commit ca3d94e into develop Oct 8, 2024
8 of 9 checks passed
@araratthehero araratthehero deleted the feature/french_meal_vouchers branch October 8, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ozgur00 ozgur00 ozgur00 left review comments

@jreij jreij jreij approved these changes

Assignees
No one assigned
Labels
Feature [PRs only] Indicates a new feature addition
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@araratthehero @ozgur00 @jreij