Replace JSONObject's opt functions with nullable extensions #1815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreij
added
the
Chore
OscarSpruit
reviewed
Oct 10, 2024
| null instead. | ||
| """.trimIndent().replace(Regex("(\n*)\n"), "$1"), | ||
| implementation = Implementation(JSONOptFunctionsDetector::class.java, Scope.JAVA_FILE_SCOPE), | ||
| category = Category.I18N, |
There was a problem hiding this comment.
CUSTOM_LINT_CHECKS is a better category I think
…n, optInt, optLong and optDouble These functions are non nullable and return arbitrary default values which could cause unexpected bugs. We should use our internal extension functions that return null instead COAND-1003
The opt functions are non nullable and return arbitrary default values which could cause unexpected bugs COAND-1003
jreij
force-pushed
the
chore/json-opt-functions
branch
from
4187f70
to
694ae15
Compare
✅ No public API changes |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
optString,optBoolean,optInt,optLongandoptDouble) with nullable extensions. These functions are non nullable and return arbitrary default values which could cause unexpected bugs.Checklist
COAND-1003