-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Google Pay button styling #1820
Open
OscarSpruit
wants to merge
4
commits into
feature/google-pay
Choose a base branch
from
feature/google-pay-button-styling
base: feature/google-pay
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
COAND-942
COAND-942
OscarSpruit
added
the
Chore
[PRs only] Indicates any task that does not need to be mentioned in the public release notes
label
Oct 11, 2024
✅ No public API changes |
Quality Gate passedIssues Measures |
jreij
reviewed
Oct 11, 2024
@@ -8,7 +8,7 @@ | |||
|
|||
<resources> | |||
|
|||
<style name="GooglePayButton"> | |||
<item name="buttonTheme">light</item> | |||
<style name="AdyenCheckout.GooglePay.Button"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we/merchants still need to do this manually?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Chore
[PRs only] Indicates any task that does not need to be mentioned in the public release notes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make it possible to style the Google Pay button both through code and XML. Where code has priority.
Checklist
COAND-942