Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Pay button styling #1820

Open
wants to merge 4 commits into
base: feature/google-pay
Choose a base branch
from

Conversation

OscarSpruit
Copy link
Contributor

Description

Make it possible to style the Google Pay button both through code and XML. Where code has priority.

Checklist

  • PR is labelled
  • Code is unit tested
  • Changes are tested manually

COAND-942

@OscarSpruit OscarSpruit added the Chore [PRs only] Indicates any task that does not need to be mentioned in the public release notes label Oct 11, 2024
@OscarSpruit OscarSpruit requested a review from a team as a code owner October 11, 2024 12:46
Copy link

✅ No public API changes

Copy link

sonarcloud bot commented Oct 11, 2024

@@ -8,7 +8,7 @@

<resources>

<style name="GooglePayButton">
<item name="buttonTheme">light</item>
<style name="AdyenCheckout.GooglePay.Button">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we/merchants still need to do this manually?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Chore [PRs only] Indicates any task that does not need to be mentioned in the public release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants