Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pw 6688 checkout api v69 #754

Merged
merged 12 commits into from
Jun 15, 2022
Merged

Pw 6688 checkout api v69 #754

merged 12 commits into from
Jun 15, 2022

Conversation

wboereboom
Copy link
Contributor

@wboereboom wboereboom commented Jun 1, 2022

Description
Updated Checkout API models to v69

Tested scenarios
updated and ran all unit tests
ran e2e tests

@@ -33,33 +33,31 @@
import java.util.List;
import com.adyen.model.Amount;
import com.adyen.model.Split;
import io.swagger.v3.oas.annotations.media.Schema;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import io.swagger.v3.oas.annotations.media.Schema;

src/main/java/com/adyen/model/checkout/Phone.java Outdated Show resolved Hide resolved
src/main/java/com/adyen/model/checkout/SDKEphemPubKey.java Outdated Show resolved Hide resolved
@@ -73,7 +73,7 @@ public enum ShopperInteractionEnum {
@SerializedName("Moto") MOTO("Moto");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this class

michaelpaul
michaelpaul previously approved these changes Jun 3, 2022
@michaelpaul
Copy link
Contributor

@wboereboom I noticed that we don't have a CardDetails model yet. It's used on /payments https://github.com/Adyen/adyen-openapi/blob/main/json/CheckoutService-v69.json#L8780. Could you add it too in this PR?

wboereboom and others added 3 commits June 14, 2022 08:28
…java

Co-authored-by: Alexandros Moraitis <alexandros.moraitis@adyen.com>
Co-authored-by: Alexandros Moraitis <alexandros.moraitis@adyen.com>
Co-authored-by: Alexandros Moraitis <alexandros.moraitis@adyen.com>
@wboereboom
Copy link
Contributor Author

@michaelpaul in the Java lib this is taken care of by DefaultPaymentMethodDetails.

@wboereboom wboereboom merged commit c87d6ed into develop Jun 15, 2022
@wboereboom wboereboom deleted the PW-6688-checkout_api_v69 branch June 15, 2022 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants