Add 'redirectFromTop' config prop to allow top level redirect when Checkout loaded in an iframe #2325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eckout loaded in an iframe
sponglord
requested review from
marcperez,
pabloai,
m1aw,
ribeiroguilherme and
longyulongyu
as code owners
🦋 Changeset detectedLatest commit: 19b6c8c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Size Change: +420 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
packages/lib/src/components/Redirect/components/RedirectShopper/RedirectShopper.tsx
Outdated
Show resolved
Hide resolved
longyulongyu
approved these changes
Sep 11, 2023
…s function clearer
|
Kudos, SonarCloud Quality Gate passed! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If the merchant is running their site within an iframe*, they can now specify a
redirectFromTopWhenInIframeboolean in the Checkout config.Then, if we end up with a
Redirectaction, we check for ourselves if the site is running in an iframe and, if it is, andredirectFromTopWhenInIframeis set totrue, then we will attempt to perform the redirect on the top level, parent, window rather than the window holding the iframe*Caveat: We don't recommend the use of iframes for hosting Checkout. We cannot guarantee that all payment methods will work when inside an iframe (ApplePay, GooglePay etc). Nor can we guarantee that pages outside of our control e.g. Issuer created pages that are part of the 3DS2 process, will perform correctly.
Tested scenarios
Manually tested that both
formsubmits andwindow.location.assignhappen on the top level window when checkout hosted in an iframe andredirectFromTopWhenInIframeis set to true.New unit test added.
Fixed issue: #2316