Update DonationComponent UI #2934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joao-m-santos
requested review from
marcperez,
pabloai,
sponglord,
m1aw,
ribeiroguilherme and
longyulongyu
as code owners
🦋 Changeset detectedLatest commit: 49bbad1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
joao-m-santos
force-pushed
the
update-donation-component-ui
branch
from
3bf9e31 to
89f225a
Compare
longyulongyu
reviewed
Nov 6, 2024
| <div className="adyen-checkout__campaign-container"> | ||
| <Img className="adyen-checkout__campaign-background-image" style={{ backgroundImage }} backgroundUrl={bannerUrl} /> | ||
| <div className="adyen-checkout__campaign"> | ||
| <a href={nonprofitUrl} className="adyen-checkout__campaign-link" target="_blank" rel="noopener noreferrer"> |
There was a problem hiding this comment.
Hey @joao-m-santos it looks nice overall. Thanks for contributing!
Small question, how does the ui look like when there is no nonprofitUrl? Previously we would render plain text.
There was a problem hiding this comment.
Good point - I will address this so that it behaves like it did previously
joao-m-santos
force-pushed
the
update-donation-component-ui
branch
from
89f225a to
7fa3878
Compare
joao-m-santos
force-pushed
the
update-donation-component-ui
branch
from
7fa3878 to
49bbad1
Compare
longyulongyu
approved these changes
Nov 7, 2024
Merged
longyulongyu
added a commit
that referenced
this pull request
Nov 12, 2024
This reverts commit 1541573.
longyulongyu
added a commit
that referenced
this pull request
Nov 12, 2024
longyulongyu
pushed a commit
that referenced
this pull request
Nov 22, 2024
(cherry picked from commit 1541573)
longyulongyu
added a commit
that referenced
this pull request
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the look & feel of the Donation checkout component, as per the new design.
Tested scenarios
Ran the existing tests, successfully