Rework how charon represents regions #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonmarcho
reviewed
Dec 11, 2024
| | Bound _ -> RVar var | ||
|
|
||
| method! visit_region_id_set _ (ids : region_id_set) : region_id_set = | ||
| RegionId.Set.map get_region_id ids |
There was a problem hiding this comment.
I just have a request here: I want to override the visit_abstraction method. The reason is that region_id_set, similarly to region_id, is not a super specific type: maybe we will use this type elsewhere in the future, and I want to make sure we notice it if we do this update. I can make the change myself if you want.
There was a problem hiding this comment.
If you don't mind, I'll leave that to you
sonmarcho
reviewed
Dec 11, 2024
| @@ -249,7 +237,7 @@ class ['self] map_typed_avalue_base = | |||
| fun _ m -> m | |||
|
|
|||
| method visit_region_id_set : 'env -> region_id_set -> region_id_set = | |||
| fun env ids -> RegionId.Set.map (self#visit_region_id env) ids | |||
| fun _ s -> s | |||
There was a problem hiding this comment.
Note to myself: I want to change this in a subsequent PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion PR to AeneasVerif/charon#492.
Now charon uses
Freefor regions bound in the signature, which makes it possible to remove a bunch of code in aeneas that substituted fresh free region ids. This change required that we mergefree_region_idandbound_region_id. Fortunately, aeneas never touches bound regions anymore, so there is no ambiguity between those at the moment. The one possible ambiguity is that aeneas generates fresh region ids, which therefore do not correspond to variables bound in the signature.