Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify the use of region_id_set #397

Merged
merged 2 commits into from
Dec 12, 2024
Merged

Clarify the use of region_id_set #397

merged 2 commits into from
Dec 12, 2024

Conversation

sonmarcho
Copy link
Member

There might be confusions when using the visit_region_id and visit_region_id_set visitors. In order to prevent future mistakes, I made sure the visitors which might read region ids do not directly use visit_region_id_set.

@sonmarcho sonmarcho changed the title Clarity the use of region_id_set Clarify the use of region_id_set Dec 12, 2024
@sonmarcho sonmarcho enabled auto-merge (squash) December 12, 2024 13:58
@sonmarcho sonmarcho merged commit 0fd53a8 into main Dec 12, 2024
6 checks passed
@sonmarcho sonmarcho deleted the son/regions branch December 12, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant