Clean up region variables #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 5, 2024
In preparation for what comes next.
Nadrieril
force-pushed
the
pre-debruijn
branch
from
70ff3a8 to
c61d978
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inside Charon, all variables are bound variables that correspond to a known binder in the AST. When manipulating the AST and variables however, we substitute such variables to be bound in a current context instead; these are called "free variables". So far in Charon we have no use for these, but they are used all over the place in Aeneas, and therefore exist in the AST of charon-ml.
This PR first clarifies the distinction between these two kinds of variables by renaming the ids to
free_region_idandbound_region_id, then adds free variables to the rust side (both for clarify and potential future uses). Finally this factors out a little enum that represents either of these variables, with intent to use it for the other type-level variables in a follow-up PR.