Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it compile on Windows #25

Open
aheck opened this issue Jul 23, 2022 · 1 comment
Open

Make it compile on Windows #25

aheck opened this issue Jul 23, 2022 · 1 comment

Comments

@aheck
Copy link
Contributor

aheck commented Jul 23, 2022

Out of the box libtsm doesn't compile on Windows.

There is a patch by RadAd, though. When cherry picked into a current version of libtsm it worked flawlessly for me.

RadAd@f879875

It would be great if this could be merged. Being able to build libtsm on Linux, macOS and Windows without the need to make any modifications to the code and the cmake files would be awesome.

If some improvements need to be made before merging I'm ready to volunteer.
@Aetf
Copy link
Owner

Aetf commented Jul 25, 2022

I do have some comments. Could you create a PR with that patch and we can continue there?

@Aetf Aetf mentioned this issue Jul 25, 2022
Merged
aheck added a commit to aheck/libtsm that referenced this issue Dec 29, 2022
@aheck
Fix code and build system to build on Visual C++ (Aetf#25)
94ccb66 
This commit is based on work from RadAd (RadAd/libtsm@f879875)

It also adds GitHub Actions support for Windows, changes code that
relied on gcc extensions, and introduces Conan to install libcheck in
a platform agnostic way.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aheck @Aetf