test: upgrade tests for 8488 smartWallet with promiseWatchers #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chris-Hibbert
force-pushed
the
8445-upgradeWF
branch
2 times, most recently
from
0934e3d
to
9d0ce1f
Compare
turadg
force-pushed
the
8445-upgradeWF
branch
from
9d0ce1f
to
4e615ee
Compare
turadg
requested changes
Nov 30, 2023
There was a problem hiding this comment.
It was failing due to the inadvertent changes to b:zoe1. I cleaned things up so I expect this to pass CI.
I'm requesting changes for the landed Agoric/agoric-sdk#8488 to be the bundle.
Chris-Hibbert
pushed a commit
to Agoric/agoric-sdk
that referenced
this pull request
Dec 6, 2023
refactor: refactor smartWallet to use watchedPromises pulled offers.js and payments.js into smartWallet.js as they shared plenty of state that needs to be durable in order to be callable from the watchedPromise. build an upgrade proposal; tested in Agoric/agoric-3-proposals#34
Chris-Hibbert
pushed a commit
to Agoric/agoric-sdk
that referenced
this pull request
Dec 6, 2023
refactor: refactor smartWallet to use watchedPromises pulled offers.js and payments.js into smartWallet.js as they shared plenty of state that needs to be durable in order to be callable from the watchedPromise. build an upgrade proposal; tested in Agoric/agoric-3-proposals#34
Chris-Hibbert
pushed a commit
to Agoric/agoric-sdk
that referenced
this pull request
Dec 11, 2023
refactor: refactor smartWallet to use watchedPromises pulled offers.js and payments.js into smartWallet.js as they shared plenty of state that needs to be durable in order to be callable from the watchedPromise. build an upgrade proposal; tested in Agoric/agoric-3-proposals#34
Inserted walletFactory as a: built submission files in #8488 Instructions for manual testing of results are in manual-test.md
Chris-Hibbert
force-pushed
the
8445-upgradeWF
branch
from
6ce1c1b
to
c104e15
Compare
Chris-Hibbert
pushed a commit
to Agoric/agoric-sdk
that referenced
this pull request
Dec 14, 2023
pulled offers.js and payments.js into smartWallet.js as they shared plenty of state that needs to be durable in order to be callable from the watchedPromise. build an upgrade proposal; tested in Agoric/agoric-3-proposals#34
Chris-Hibbert
pushed a commit
to Agoric/agoric-sdk
that referenced
this pull request
Dec 14, 2023
pulled offers.js and payments.js into smartWallet.js as they shared plenty of state that needs to be durable in order to be callable from the watchedPromise. build an upgrade proposal; tested in Agoric/agoric-3-proposals#34
Chris-Hibbert
pushed a commit
to Agoric/agoric-sdk
that referenced
this pull request
Dec 14, 2023
pulled offers.js and payments.js into smartWallet.js as they shared plenty of state that needs to be durable in order to be callable from the watchedPromise. build an upgrade proposal; tested in Agoric/agoric-3-proposals#34
This was referenced Dec 15, 2023
Chris-Hibbert
pushed a commit
to Agoric/agoric-sdk
that referenced
this pull request
Dec 15, 2023
pulled offers.js and payments.js into smartWallet.js as they shared plenty of state that needs to be durable in order to be callable from the watchedPromise. build an upgrade proposal; tested in Agoric/agoric-3-proposals#34
Chris-Hibbert
pushed a commit
to Agoric/agoric-sdk
that referenced
this pull request
Dec 15, 2023
pulled offers.js and payments.js into smartWallet.js as they shared plenty of state that needs to be durable in order to be callable from the watchedPromise. build an upgrade proposal; tested in Agoric/agoric-3-proposals#34
Chris-Hibbert
pushed a commit
to Agoric/agoric-sdk
that referenced
this pull request
Jan 2, 2024
pulled offers.js and payments.js into smartWallet.js as they shared plenty of state that needs to be durable in order to be callable from the watchedPromise. build an upgrade proposal; tested in Agoric/agoric-3-proposals#34
Chris-Hibbert
pushed a commit
to Agoric/agoric-sdk
that referenced
this pull request
Jan 2, 2024
pulled offers.js and payments.js into smartWallet.js as they shared plenty of state that needs to be durable in order to be callable from the watchedPromise. build an upgrade proposal; tested in Agoric/agoric-3-proposals#34
Chris-Hibbert
pushed a commit
to Agoric/agoric-sdk
that referenced
this pull request
Jan 4, 2024
pulled offers.js and payments.js into smartWallet.js as they shared plenty of state that needs to be durable in order to be callable from the watchedPromise. build an upgrade proposal; tested in Agoric/agoric-3-proposals#34
Chris-Hibbert
pushed a commit
to Agoric/agoric-sdk
that referenced
this pull request
Jan 4, 2024
pulled offers.js and payments.js into smartWallet.js as they shared plenty of state that needs to be durable in order to be callable from the watchedPromise. build an upgrade proposal; tested in Agoric/agoric-3-proposals#34
Chris-Hibbert
pushed a commit
to Agoric/agoric-sdk
that referenced
this pull request
Jan 4, 2024
pulled offers.js and payments.js into smartWallet.js as they shared plenty of state that needs to be durable in order to be callable from the watchedPromise. build an upgrade proposal; tested in Agoric/agoric-3-proposals#34
Chris-Hibbert
pushed a commit
to Agoric/agoric-sdk
that referenced
this pull request
Jan 5, 2024
pulled offers.js and payments.js into smartWallet.js as they shared plenty of state that needs to be durable in order to be callable from the watchedPromise. build an upgrade proposal; tested in Agoric/agoric-3-proposals#34
Chris-Hibbert
pushed a commit
to Agoric/agoric-sdk
that referenced
this pull request
Jan 16, 2024
pulled offers.js and payments.js into smartWallet.js as they shared plenty of state that needs to be durable in order to be callable from the watchedPromise. build an upgrade proposal; tested in Agoric/agoric-3-proposals#34
Chris-Hibbert
pushed a commit
to Agoric/agoric-sdk
that referenced
this pull request
Jan 18, 2024
pulled offers.js and payments.js into smartWallet.js as they shared plenty of state that needs to be durable in order to be callable from the watchedPromise. build an upgrade proposal; tested in Agoric/agoric-3-proposals#34
Chris-Hibbert
pushed a commit
to Agoric/agoric-sdk
that referenced
this pull request
Jan 18, 2024
pulled offers.js and payments.js into smartWallet.js as they shared plenty of state that needs to be durable in order to be callable from the watchedPromise. build an upgrade proposal; tested in Agoric/agoric-3-proposals#34
mhofman
pushed a commit
to Agoric/agoric-sdk
that referenced
this pull request
Jan 19, 2024
pulled offers.js and payments.js into smartWallet.js as they shared plenty of state that needs to be durable in order to be callable from the watchedPromise. build an upgrade proposal; tested in Agoric/agoric-3-proposals#34
Chris-Hibbert
pushed a commit
to Agoric/agoric-sdk
that referenced
this pull request
Jan 20, 2024
pulled offers.js and payments.js into smartWallet.js as they shared plenty of state that needs to be durable in order to be callable from the watchedPromise. build an upgrade proposal; tested in Agoric/agoric-3-proposals#34
This was referenced Jan 22, 2024
anilhelvaci
pushed a commit
to Jorge-Lopes/agoric-sdk
that referenced
this pull request
Feb 16, 2024
pulled offers.js and payments.js into smartWallet.js as they shared plenty of state that needs to be durable in order to be callable from the watchedPromise. build an upgrade proposal; tested in Agoric/agoric-3-proposals#34
anilhelvaci
pushed a commit
to Jorge-Lopes/agoric-sdk
that referenced
this pull request
Mar 4, 2024
pulled offers.js and payments.js into smartWallet.js as they shared plenty of state that needs to be durable in order to be callable from the watchedPromise. build an upgrade proposal; tested in Agoric/agoric-3-proposals#34
|
this is included in an upgrade now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inserted walletFactory as a:
built submission files in #8488
enhanced vat-status.js to look up vats by name (as substring)