Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remote builds #88

Merged
merged 10 commits into from
Feb 7, 2024
Merged

remote builds #88

merged 10 commits into from
Feb 7, 2024

Conversation

turadg
Copy link
Member

@turadg turadg commented Feb 1, 2024

closes: #85

Building all the use images in #69 takes much more disk space. The hacks to make that work broke the image merging job that had worked previously.

After exploring many options, this PR adopts Depot.dev to build remotely. Their concurrent multiplatform bake greatly simplifies the CI. It removes the need to self-host our ARM runner and the large persistent build cache greatly speeds up our builds (e.g. a JS change builds in minutes to resolve the image caches instead of over an hour to re-run all the chain operations.)

There are some other changes that should be evident from the commit messages.

Test plan

@turadg turadg force-pushed the ta/try-depot branch 8 times, most recently from 6c959ef to 732117c Compare February 3, 2024 00:12
@turadg turadg marked this pull request as ready for review February 3, 2024 01:49
@michaelfig
Copy link
Member

Please mention me again when the tests are passing. Thanks!

@turadg
Copy link
Member Author

turadg commented Feb 4, 2024

Please mention me again when the tests are passing. Thanks!

@michaelfig please provide your perspective on:

  • "build" command only for downstream repos
  • reliance on "depot" and how it's factored
  • documentation requirements

I don't expect any of those to change in the course of getting the tests back to green. (They were green when I first requested review)

Happy to sync if more context is needed.

Copy link
Member

@michaelfig michaelfig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • "build" command only for downstream repos

That looks good.

  • reliance on "depot" and how it's factored

Also good. The CI changes look like I would have hoped.

  • documentation requirements

I think things are sufficiently documented.

Nothing here looks like it needs any drastic changes, but I haven't yet tried to reproduce the build steps on my own machine, which I believe is a prerequisite for being able to give explicit approval.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
packages/synthetic-chain/src/lib/agd-lib.ts Outdated Show resolved Hide resolved
Copy link
Member

@michaelfig michaelfig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Onward and upward!

@turadg turadg merged commit 954b5a0 into main Feb 7, 2024
1 check passed
@turadg turadg deleted the ta/try-depot branch February 7, 2024 00:21
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This rename causes agoric-sdk a3p-integration tests to fail.

@mhofman
Copy link
Member

mhofman commented Feb 7, 2024

Sorry for not reviewing this earlier, and I'm not even sure I would have caught it, but synthetic-chain and base image changes cannot be coupled as there may be existing consumers of a specific version of the synthetic-chain package that use the latest a3p images also produced by this repo. In this case agoric-sdk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

multiplatform images not building
3 participants