Skip to content

Commit

Permalink
fix(swingset): force flaky GC test to use XS only
Browse files Browse the repository at this point in the history
Sometimes, for reasons we don't entirely understand, Node.js doesn't
garbage-collect objects when we tell it to, and we get flaky
GC-checking tests. This applies our usual fix, which is to only run
those tests under XS.

It also stops attempting to use `test.serial` as a workaround.

refs #3240
refs #5575
fixes #9089
  • Loading branch information
warner authored and turadg committed Mar 27, 2024
1 parent 8e87d58 commit a3fe3be
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions packages/SwingSet/test/test-gc-kernel.js
Original file line number Diff line number Diff line change
Expand Up @@ -1172,14 +1172,14 @@ test('terminated vat', async t => {
});

// device receives object from vat a, returns to vat b

test.serial('device transfer', async t => {
test('device transfer', async t => {
function vatpath(fn) {
return {
sourceSpec: new URL(`gc-device-transfer/${fn}`, import.meta.url).pathname,
};
}
const config = {
defaultManagerType: 'xs-worker', // Avoid local vat nondeterminism
vats: {
bootstrap: vatpath('bootstrap-gc.js'),
left: vatpath('vat-left-gc.js'),
Expand Down

0 comments on commit a3fe3be

Please sign in to comment.