test: fix flaky tests

Agoric · Jun 2, 2021 · e49813c · e49813c
1 parent 0153529
commit e49813c
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 4 deletions.
diff --git a/.github/workflows/test-all-packages.yml b/.github/workflows/test-all-packages.yml
@@ -538,7 +538,7 @@ jobs:
     # END-RESTORE-BOILERPLATE
 
     - name: yarn test (zoe)
-      timeout-minutes: 20
+      timeout-minutes: 30
       run: cd packages/zoe && yarn test
       env:
         ESM_DISABLE_CACHE: true

diff --git a/packages/agoric-cli/integration-tests/test-workflow.js b/packages/agoric-cli/integration-tests/test-workflow.js
@@ -132,7 +132,11 @@ test('workflow', async t => {
     ]);
     finalizers.push(() => pkill(deployP.childProcess, 'SIGINT'));
 
-    timeout = setTimeout(deployResult.resolve, 120 * 1000, 'timeout');
+    timeout = setTimeout(
+      deployResult.resolve,
+      TIMEOUT_SECONDS * 1000,
+      'timeout',
+    );
     const done = await Promise.race([deployResult.promise, deployP]);
     t.is(done, 0, `deploy successful before timeout`);
     clearTimeout(timeout);

diff --git a/packages/eslint-config/eslint-config.json b/packages/eslint-config/eslint-config.json
@@ -81,6 +81,7 @@
     "jsdoc/valid-types": "off"
   },
   "ignorePatterns": [
+    "coverage/**",
     "**/output/**",
     "bundles/**",
     "dist/**",

diff --git a/packages/solo/test/test-home.js b/packages/solo/test/test-home.js
@@ -156,7 +156,7 @@ test.serial('home.localTimerService createRepeater', async t => {
   const notifier = E(localTimerService).makeNotifier(1n, 1n);
   await E(notifier).getUpdateSince();
 
-  t.is(1, handler.getCalls());
+  t.truthy(handler.getCalls() >= 1);
   t.truthy(handler.getArgs()[0] > timestamp);
 });
 

diff --git a/packages/swingset-runner/src/main.js b/packages/swingset-runner/src/main.js
@@ -1,4 +1,4 @@
-/* global globalThis __dirname */
+/* global __dirname */
 import path from 'path';
 import fs from 'fs';
 import process from 'process';