chore: do remaining.delete in the right place

Agoric · May 12, 2023 · ec7cea6 · ec7cea6
1 parent 4ba0031
commit ec7cea6
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/packages/vats/src/core/promise-space.js b/packages/vats/src/core/promise-space.js
@@ -111,6 +111,7 @@ export const makePromiseSpace = (optsOrLog = {}) => {
       const pk = makePromiseKit();
       pk.promise
         .finally(() => {
+          remaining.delete(name);
           onSettled(name, remaining);
         })
         .catch(() => {});
@@ -131,13 +132,11 @@ export const makePromiseSpace = (optsOrLog = {}) => {
       const old = provideState(name);
       nameToState.set(name, harden({ ...old, isSettling: true }));
       old.pk.resolve(value);
-      remaining.delete(name);
     };
     const reject = reason => {
       const old = provideState(name);
       nameToState.set(name, harden({ ...old, isSettling: true }));
       old.pk.reject(reason);
-      remaining.delete(name);
     };
     const reset = (reason = undefined) => {
       onReset(name);