Skip to content

Commit

Permalink
fix!: drop Node.js v12 support, require v14.15.0 or higher
Browse files Browse the repository at this point in the history
BREAKING CHANGE: The agoric-sdk as a whole now requires/advises v14.

We're leaving the individual package.jsons alone until a specific updated
requirement is found for each (e.g. SwingSet will soon bump to v14 because it
will require WeakRef). We won't be testing v12 support anywhere, but it's
possible that individual packages will still work with v12 until we believe
otherwise.

closes #1925
closes #837

Co-authored-by: Mathieu Hofman <86499+mhofman@users.noreply.github.com>
  • Loading branch information
warner and mhofman committed May 21, 2021
1 parent d7c9530 commit f014684
Show file tree
Hide file tree
Showing 5 changed files with 24 additions and 12 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ag-solo-xs.yml.DISABLED
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
- uses: actions/checkout@v2
- uses: actions/setup-node@v1
with:
node-version: '12.x'
node-version: '14.x'
- name: cache node modules
uses: actions/cache@v1
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/integration.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:

- uses: actions/setup-node@v1
with:
node-version: '12.x'
node-version: '14.x'
- name: cache node modules
uses: actions/cache@v1
with:
Expand Down
27 changes: 19 additions & 8 deletions .github/workflows/test-all-packages.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: ['12.x', '14.x']
# TODO: ['14.x', '16.x']
node-version: ['14.x']
steps:
- uses: actions/checkout@v2
with:
Expand Down Expand Up @@ -51,7 +52,8 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: ['12.x']
# note: only use one node-version
node-version: ['14.x']
steps:
- uses: actions/setup-node@v1
with:
Expand Down Expand Up @@ -83,6 +85,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
# note: only use one node-version
node-version: ['14.x']
if: ${{github.event_name == 'push' && github.ref == 'refs/heads/master'}}
steps:
Expand Down Expand Up @@ -122,6 +125,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
# note: only use one node-version
node-version: ['14.x']
if: ${{github.event_name == 'push' && github.ref == 'refs/heads/master'}}
steps:
Expand Down Expand Up @@ -177,7 +181,8 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: ['12.x', '14.x']
# TODO: ['14.x', '16.x']
node-version: ['14.x']
steps:
- uses: actions/setup-node@v1
with:
Expand Down Expand Up @@ -306,7 +311,8 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: ['12.x', '14.x']
# TODO: ['14.x', '16.x']
node-version: ['14.x']
steps:
- uses: actions/setup-node@v1
with:
Expand Down Expand Up @@ -372,7 +378,8 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: ['12.x', '14.x']
# TODO: ['14.x', '16.x']
node-version: ['14.x']
steps:
- uses: actions/setup-node@v1
with:
Expand Down Expand Up @@ -410,7 +417,8 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: ['12.x', '14.x']
# TODO: ['14.x', '16.x']
node-version: ['14.x']
steps:
- uses: actions/setup-node@v1
with:
Expand Down Expand Up @@ -457,7 +465,8 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: ['12.x', '14.x']
# TODO: ['14.x', '16.x']
node-version: ['14.x']
steps:
- uses: actions/setup-node@v1
with:
Expand Down Expand Up @@ -502,7 +511,8 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: ['12.x', '14.x']
# TODO: ['14.x', '16.x']
node-version: ['14.x']
steps:
- uses: actions/setup-node@v1
with:
Expand Down Expand Up @@ -540,6 +550,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
# note: only use one node-version, maybe
node-version: ['14.x']
steps:
- uses: actions/setup-node@v1
Expand Down
3 changes: 2 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@ to use.
## Prerequisites

* Git
* Node.js (version 12.14.1 or higher)
* Node.js LTS (version 14.15.0 or higher)
* we generally support the latest LTS release: use [nvm](https://github.com/nvm-sh/nvm) to keep your local system up-to-date
* Yarn (`npm install -g yarn`)

Any version of Yarn will do: the `.yarnrc` file should ensure that all
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@
"typescript": "^4.2.3"
},
"engines": {
"node": ">=12.14.1"
"node": ">=14.15.0"
},
"scripts": {
"OFF-clean": "yarn workspaces run clean",
Expand Down

0 comments on commit f014684

Please sign in to comment.