Skip to content

Commit

Permalink
fix: Disallow Node.js major version >20 (#9630)
Browse files Browse the repository at this point in the history
refs: #9622

## Description
#9623 claimed to enforce Node.js versions ^18.12 or ^20.9, but due to a typo allows arbitrarily high versions to pass the check. This corrects it to enforce that the major version is exactly 18 or 20.

### Security Considerations
None.

### Scaling Considerations
n/a

### Documentation Considerations
Matches the [README](https://github.com/Agoric/agoric-sdk?tab=readme-ov-file#prerequisites).

### Testing Considerations
Checked by integration testing in CI.

### Upgrade Considerations
Will need an update for supporting Node.js v22 when that enters LTS (ref #9265).
  • Loading branch information
mergify[bot] authored and gibson042 committed Jul 1, 2024
2 parents b0f1f66 + 972dd6f commit f91b395
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion repoconfig.sh
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ golang_version_check() {
nodejs_version_check() {
{
[ "$1" -eq 18 ] && [ "$2" -ge 12 ] && return 0
[ "$1" -ge 20 ] && [ "$2" -ge 9 ] && return 0
[ "$1" -eq 20 ] && [ "$2" -ge 9 ] && return 0
} 2> /dev/null
echo 1>&2 "need Node.js LTS version ^18.12 or ^20.9, found $1.$2.$3"
return 1
Expand Down

0 comments on commit f91b395

Please sign in to comment.