Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Virtual Objects in Vaults #4345

Closed
Chris-Hibbert opened this issue Jan 21, 2022 · 4 comments · Fixed by #4913, #5116 or #5173
Closed

Use Virtual Objects in Vaults #4345

Chris-Hibbert opened this issue Jan 21, 2022 · 4 comments · Fixed by #4913, #5116 or #5173
Assignees
@turadg
Labels
code-style defensive correctness patterns; readability thru consistency Core Economy OBSOLETE in favor of INTER-protocol enhancement New feature or request Inter-protocol Overarching Inter Protocol performance Performance related issues resource-exhaustion Threats to availability from resource exhaustion attacks Vaults VaultFactor (née Treasury)
Milestone
Mainnet 1 RC0

Comments

@Chris-Hibbert
Copy link
Contributor

What is the Problem Being Solved?

For MainNet 1, we intend to support durable objects for restart and upgrade.

Description of the Design

Collect a catalogue of all the persistent data types in Vaults, and convert them to Virtual Objects.

Security Considerations

This is about durability. It shouldn't have broader security implications.

Test Plan

Presumably extensive.
@Chris-Hibbert Chris-Hibbert added enhancement New feature or request performance Performance related issues Medium Core Economy OBSOLETE in favor of INTER-protocol code-style defensive correctness patterns; readability thru consistency Inter-protocol Overarching Inter Protocol resource-exhaustion Threats to availability from resource exhaustion attacks labels Jan 21, 2022
@Chris-Hibbert Chris-Hibbert self-assigned this Jan 21, 2022
@Tartuffo Tartuffo added MN-1 restival to be done before RUN Protocol Purple Team festival and removed MN-1 labels Jan 21, 2022
@Tartuffo
Copy link
Contributor

Also related to #4344.

@Tartuffo Tartuffo assigned turadg and unassigned dckc and Chris-Hibbert Feb 7, 2022
@Tartuffo Tartuffo removed the MN-1 label Feb 7, 2022
@dckc dckc mentioned this issue Feb 8, 2022
Open
1 task
@Chris-Hibbert
Copy link
Contributor Author

#4341 is a subset of this work.

@turadg
Copy link
Member

turadg commented Feb 10, 2022 •
edited
Loading

#4341 is a subset of this work.

True. For estimation I was reading this one as the work to be done to finish the job after #4341. So i'd call that one a blocker of this, because that one uses the Collections API and this ticket is to enable durable: true and make that fly.

@dtribble dtribble mentioned this issue Feb 10, 2022
Closed
@turadg turadg mentioned this issue Feb 10, 2022
Merged
7 tasks
@turadg turadg mentioned this issue Feb 25, 2022
Closed
@turadg
Copy link
Member

turadg commented Feb 25, 2022

#4618 illustrates best practices

@Tartuffo Tartuffo removed the restival to be done before RUN Protocol Purple Team festival label Feb 28, 2022
@turadg turadg mentioned this issue Mar 1, 2022
Closed
@Chris-Hibbert Chris-Hibbert added the Vaults VaultFactor (née Treasury) label Mar 10, 2022
@Tartuffo Tartuffo added this to the Mainnet 1 milestone Mar 23, 2022
@turadg turadg mentioned this issue Mar 24, 2022
Closed
@turadg turadg mentioned this issue Mar 24, 2022
Merged
@turadg turadg linked a pull request Mar 24, 2022 that will close this issue
refactor(run-protocol): innerVault as virtual object #4913
Merged
@mergify mergify bot closed this as completed in #4913 Mar 25, 2022
@turadg turadg reopened this Mar 26, 2022
@Tartuffo Tartuffo modified the milestones: Mainnet 1, RUN Protocol RC0 Apr 6, 2022
@Tartuffo Tartuffo removed the Medium label Apr 8, 2022
@turadg turadg mentioned this issue Apr 8, 2022
Merged
@Tartuffo Tartuffo modified the milestones: Mainnet 1, RUN Protocol RC0 Apr 11, 2022
This was referenced Apr 13, 2022
Merged
Merged
Closed
@mergify mergify bot closed this as completed in #5116 Apr 19, 2022
@turadg turadg mentioned this issue Apr 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turadg turadg

Labels
code-style defensive correctness patterns; readability thru consistency Core Economy OBSOLETE in favor of INTER-protocol enhancement New feature or request Inter-protocol Overarching Inter Protocol performance Performance related issues resource-exhaustion Threats to availability from resource exhaustion attacks Vaults VaultFactor (née Treasury)
Projects
None yet
Milestone
Mainnet 1 RC0
4 participants
@turadg @dckc @Tartuffo @Chris-Hibbert