Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: virtualize payments, purses, ledger #4618

Merged
merged 6 commits into from
Mar 22, 2022
Merged

Conversation

erights
Copy link
Member

@erights erights commented Feb 21, 2022

Virtualize payment, paymentLedger, and purse,depositFacet together as a multi-faceted unit.

This does not virtualize everything that will need to be durable to support upgrade.

This does not even virtualize everything of high arity, needed for scaling, as it does not virtualize the per-purse notifier.

@erights erights requested a review from FUDCo February 21, 2022 05:14
@erights erights self-assigned this Feb 21, 2022
@erights erights force-pushed the markm-virtualize-ERTP branch 2 times, most recently from bd23614 to e4681fd Compare February 21, 2022 21:34
@erights erights changed the base branch from master to 4606-refactor-makeKind February 21, 2022 21:38
@erights erights force-pushed the markm-virtualize-ERTP branch 2 times, most recently from a085d12 to 6c6d8f6 Compare February 22, 2022 02:00
@erights erights marked this pull request as ready for review February 22, 2022 02:00
@FUDCo FUDCo force-pushed the 4606-refactor-makeKind branch 2 times, most recently from b2fa856 to e40674b Compare February 24, 2022 01:42
Base automatically changed from 4606-refactor-makeKind to master February 24, 2022 02:02
@erights erights marked this pull request as draft March 21, 2022 19:40
@erights erights requested a review from turadg March 21, 2022 20:46
@erights erights marked this pull request as ready for review March 21, 2022 20:46
@erights
Copy link
Member Author

erights commented Mar 21, 2022

Assuming it passes CI enough, this is now ready for review. Thanks!

@erights
Copy link
Member Author

erights commented Mar 21, 2022

Solving a CI failure led me down a rabbit hold, resulting in 981bc1e which we should definitely discuss before merging. I would like to avoid merging this as part of this PR.

However, without it, the generated file ui-components/compiled/test/components/test-NatAmountInput.js fails, apparently because its imports include ERTP, which now depends on storeModule, which depends on the global variable VatData. However, apparently this generated file is run in an environment in which no one installs VatData.

See #4255

@erights
Copy link
Member Author

erights commented Mar 21, 2022

Yay! CI passes! But only with the 981bc1e kludge. Is there a better way?

Copy link
Member

@warner warner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a good start. I'm not excited about the VatData thing, but I figure we'll find a solution for that sooner or later.

While reviewing this, I realized we have a GC/determinism problem, which I wrote up in #4892. It's not specific to this conversion though, so it shouldn't hold up this PR.

@erights erights changed the title WIP: virtualize payments, purses, ledger fix: virtualize payments, purses, ledger Mar 22, 2022
Copy link
Member

@turadg turadg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Golden!

@erights erights added the automerge:squash Automatically squash merge label Mar 22, 2022
@mergify mergify bot merged commit dfeda1b into master Mar 22, 2022
@mergify mergify bot deleted the markm-virtualize-ERTP branch March 22, 2022 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge:squash Automatically squash merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants