fix: quick "fix" of a red squiggle problem #4447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhofman
approved these changes
Feb 3, 2022
|
#4413 is the proper fix, but it requires endojs/endo#1025, which is breaking change and requires a proper release of endo packages (unless we take the approach of temporarily vendoring-in as patches like I did in the PR) |
erights
force-pushed
the
4444-markm-quick-ambient-type-fix
branch
from
509e058
to
c78f601
Compare
Thanks. So I'll proceed with this one in the meantime. |
dtribble
pushed a commit
that referenced
this pull request
Feb 4, 2022
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applies suggestion from #4444 (comment) at a place that seems to make more red squiggles to away.
If I apply the quick "fix" to store/src/types.js itself, then checkKey.js has lots of red squiggles that don't disappear, either with or without the same quick fix applied there. However, if I apply the quick fix only there, the red squiggles go away both places.
I also searched for
/// <reference types="ses"/>and visually verified that vscode doesn't show any red squiggles on the 20 matching files after this change.If a principled change is about to arrive soon that fixes this correctly, then by all means let's not merge this PR in the meantime. What PR is that?