Import explicit types from @endo/marshal
#4413
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelfig
force-pushed
the
mfig-marshal-explicit-jsdoc
branch
from
cf257c4
to
486f37e
Compare
mhofman
reviewed
Jan 28, 2022
erights
reviewed
Jan 28, 2022
mhofman
force-pushed
the
mfig-marshal-explicit-jsdoc
branch
from
486f37e
to
6ede1b0
Compare
mhofman
force-pushed
the
mfig-marshal-explicit-jsdoc
branch
from
6ede1b0
to
9c9485b
Compare
|
Rebased on top of #4420, added a few more explicit type import that were needed, and included the patch to the endo packages so that one can try this without jumping through hoops. |
It doesn't anymore ;) |
mhofman
force-pushed
the
warner-update-typescript
branch
2 times, most recently
from
a9f3176
to
9dc29ca
Compare
mhofman
force-pushed
the
mfig-marshal-explicit-jsdoc
branch
from
9c9485b
to
7a08fc2
Compare
mhofman
force-pushed
the
warner-update-typescript
branch
2 times, most recently
from
4449e2a
to
9324cfe
Compare
mhofman
force-pushed
the
mfig-marshal-explicit-jsdoc
branch
from
7a08fc2
to
b4d37ca
Compare
mhofman
changed the title
import('@endo/marshal/exported') JSDoc@endo/marshal
mhofman
force-pushed
the
mfig-marshal-explicit-jsdoc
branch
from
b4d37ca
to
da5e766
Compare
|
Found a few other instances of ambient use, rebased and included the patch for the final version merged on the endo side. I think the best approach is to keep this in draft until @kriskowal bumps the versions, and then just use the first commit here. |
mhofman
reviewed
Feb 4, 2022
| @@ -159,7 +159,7 @@ | |||
| * @property {string} 0 Kernel slot designating the device node that is the target of | |||
| * the invocation | |||
| * @property {string} 1 A string naming the method to be invoked | |||
| * @property {CapData} 2 A capdata object containing the arguments to the invocation | |||
| * @property {import('@endo/marshal').CapData<unknown>} 2 A capdata object containing the arguments to the invocation | |||
This was referenced Feb 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #XXXX
refs: #XXXX
Description
Informational for @kriskowal (and @mhofman if interested). This is the other side of endojs/endo#1025 , which must be merged before this work can continue.
Security Considerations
Documentation Considerations
Testing Considerations