manualTimer runs differently when each tick awaited

[turadg]

What is the Problem Being Solved?

Different tasks are fired when using tickN. In some tests this affects the interest calculation. See // FIXME test result relies on awaiting each tick.

example from test-vaultFactory

using tickN:

    ℹ @@ tick:604800: 5n interest tick @@
    ℹ && running a task scheduled for 604800. &&
    ℹ @@ tick:1209600: 5n interest tick @@
    ℹ @@ tick:1814400: 5n interest tick @@
    ℹ @@ tick:2419200: 5n interest tick @@
    ℹ @@ tick:3024000: 5n interest tick @@
    ℹ @@ schedule task for:3628800, currently: 3024000 @@

using await tick() in a loop:

    ℹ @@ tick:604800: 5n interest tick with awaits @@
    ℹ && running a task scheduled for 604800. &&
    ℹ @@ tick:1209600: 5n interest tick with awaits @@
    ℹ @@ tick:1814400: 5n interest tick with awaits @@
    ℹ @@ tick:2419200: 5n interest tick with awaits @@
    ℹ @@ tick:3024000: 5n interest tick with awaits @@
    ℹ @@ schedule task for:3628800, currently: 3024000 @@
    ℹ @@ tick:3628800 @@
    ℹ && running a task scheduled for 3628800. &&
    ℹ @@ schedule task for:4233600, currently: 3628800 @@
    ℹ @@ tick:4233600 @@
    ℹ && running a task scheduled for 4233600. &&
    ℹ @@ schedule task for:4838400, currently: 4233600 @@
    ℹ @@ tick:4838400 @@
    ℹ && running a task scheduled for 4838400. &&
    ℹ @@ schedule task for:5443200, currently: 4838400 @@
    ℹ @@ tick:5443200 @@
    ℹ && running a task scheduled for 5443200. &&
    ℹ @@ schedule task for:6048000, currently: 5443200 @@
    ℹ @@ tick:6048000 @@
    ℹ && running a task scheduled for 6048000. &&
    ℹ @@ schedule task for:6652800, currently: 6048000 @@

Description of the Design

Security Considerations

Test Plan

[Chris-Hibbert]

adding await eventLoopIteration(); before await timer.tick(msg); in tickN in manualTimer makes this test pass, so I think it's just a matter of waiting enough turns for the messages to get processed.

I think that's a plausible interpretation of what tickN() should do. WDYT?