5547 end event loop #5606
Merged
5547 end event loop #5606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turadg
approved these changes
Jun 15, 2022
Comment on lines
2730
to
2731
| const periods = 5; | ||
| await manualTimer.tickN(periods); |
There was a problem hiding this comment.
periods had been used for t.is(interestAccrued, periods * 2n) but not anymore and I'm not confident the math works out that cleanly for arbitrary N.
if you feel like it,
Suggested change
| const periods = 5; | |
| await manualTimer.tickN(periods); | |
| await manualTimer.tickN(5); |
packages/zoe/tools/manualTimer.js
Outdated
| * that all promises that can do resolve. | ||
| * Note that this doesn't mean all outstanding promises. | ||
| */ | ||
| export const eventLoopIteration = async () => |
Chris-Hibbert
force-pushed
the
5547-endEventLoop
branch
from
2427a39
to
a0aa9e2
Compare
Chris-Hibbert
added
the
automerge:no-update
some minor drive-by cleanups of the files that were touched.
Chris-Hibbert
force-pushed
the
5547-endEventLoop
branch
from
b62e61c
to
c664d16
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #5547
Description
add eventLoopIteration() in manualtimer's tickN()
Also moved testLoopIteration() from run-protocol to live with the manualTimer in Zoe/test
Security Considerations
None. Test only.
Documentation Considerations
None
Testing Considerations