smartWallet stops updating purse balance on upgrade

[dckc]

Describe the bug

The wallet gets a balance-updates notifier from the Purses it manages, and it correctly uses observeNotifier to follow them. Zoe hosts Issuers for IST and for invitations. The ERTP Issuer code uses transientNotifier.js to produce the balance-update notifiers. So when v9-zoe is upgraded, v43-walletFactory will see the rejected/disconnected upgrade promise, correctly go back to the notifier to get a new promise, but that notifier will be dead, and observeNotifier has no further fallbacks it can make, so the wallet will stop updating chain-storage with user balances of IST (and maybe contract invitations that it already knows about). We think either the wallet needs to react to this by asking the Purse for a new (still-merely-virtual) notifier (effectively a third-level fallback), or ERTP needs to be changed to offer durable notifiers instead of merely-virtual ones (and Zoe needs to use them, if we don't make that mode the default).

This affects any non-vbank issuer/purse.

To Reproduce

1. provision a smartWallet for an oracle operator
2. upgrade zoe
3. send a new invitation to the operator
4. oracle operator is not notified of new invitation

Expected behavior

notifications happen after zoe is upgraded

Design / Plan

• fix: watch ERTP purse balances across zoe upgrades (release branch) #8557
  • capture the bug in a test
  • diagnose
  • fix on release branch, with durability
• fix: watch ERTP purse balances across zoe upgrades #8573
  • fix on master, with durability
    • fix on 8445 add promiseWatcher to smartWallet #8488 branch

Platform Environment

mainnet1B

Additional context

from the #8245 investigation with @warner:

[dckc]

For a fix for this issue, what branch should it be based on? @warner ?

[dckc]

I added a checklist / plan to the description:

• fix: watch ERTP purse balances across zoe upgrades #8573
  • fix on 8445 add promiseWatcher to smartWallet #8488 branch, with durability
  • fix on master, with durability
• fix: watch ERTP purse balances across zoe upgrades (release branch) #8557
  • capture the bug in a test (21 Nov)
  • diagnose
  • port to branch for Wallet factory upgrade 2 branch #8593 (dev-upgrade-wallet-factory-2)
  • ship with upgrade-13

I worked with @0xpatrickdev to capture the bug in a test on 21 Nov. MFig and I diagnosed it around Nov 27. I added a fix around Nov 27 and requested review. MH's review showed that the fix for when zoe is upgraded is not independent of work to address problems when walletFactory is upgraded (#8488).

Meanwhile, I asked for clarity about whether this work should target master or the release branch (#8565); then answer is: both.

So even though review of #8488 isn't done, I suppose I should start working on that branch. Then after #8488 lands, we can land #8557 . And then we can land the version on the release branch (#8573) ... by way of the dev-upgrade-wallet-factory-2 branch started in #8593.

[dckc]

@Chris-Hibbert has kindly agreed to help with this.

[mhofman]

@Chris-Hibbert is this fixed with #8773 & #8775 ?

Edit: nvm I see it's waiting for the #8787 tests

[aj-agoric]

Moving to done as @Chris-Hibbert mentioned this was in the release branch and sufficiently tested.