fix: watch ERTP purse balances across zoe upgrades #8573
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chris-Hibbert
approved these changes
Nov 28, 2023
1 task
7 tasks
dckc
force-pushed
the
8239-port-8557
branch
2 times, most recently
from
f756c9e
to
43355f6
Compare
Chris-Hibbert
force-pushed
the
8445-addWatcher
branch
4 times, most recently
from
a251233
to
2fd24cd
Compare
Chris-Hibbert
force-pushed
the
8445-addWatcher
branch
2 times, most recently
from
19bfad6
to
cd1c09a
Compare
Chris-Hibbert
force-pushed
the
8445-addWatcher
branch
4 times, most recently
from
37b4e84
to
5ed5107
Compare
dckc
force-pushed
the
8239-port-8557
branch
3 times, most recently
from
cc1dce2
to
401e87a
Compare
|
On a re-read, I realized that this only addresses newly created smartWallets, and existing ones do not get repaired. Consider hooking into repairWalletForIncarnation2 to get access to existing smartWallets to repair them. I'm going to retract my approval, pending a fix. |
Chris-Hibbert
force-pushed
the
8239-port-8557
branch
from
ded6f35
to
76e9d45
Compare
observeNotifier() would handle upgrade disconnects if the notifiers were durable. But in @agoric/ertp, they're ephemeral, so we open-code the loop. When the offerWatchers detect an upgrade, they reschedule the watchers. We needed to ensure the wallet itself doesn't do its cleanup in that case. The test updates purse balance across upgrade - provision a smartWallet for an oracle operator - upgrade zoe; reproduce smartWallet bug - check for new invitation
Chris-Hibbert
force-pushed
the
8239-port-8557
branch
from
76e9d45
to
20e1a9a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DRAFT until:
refs: #8557
provided that lands,
fixes: #8293
Description
This is a port of #8557 from the release branch to master:
So we work around that.
Security / Scaling / Documentation / Testing / Upgrade Considerations
See #8557