Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new snapshots export command should fail early if exporting historical height #9600

Closed
mhofman opened this issue Jun 27, 2024 · 0 comments · Fixed by #9601
Closed

new snapshots export command should fail early if exporting historical height #9600

mhofman opened this issue Jun 27, 2024 · 0 comments · Fixed by #9601
Assignees
@mhofman
Labels
agoric-cosmos bug Something isn't working

Comments

@mhofman
Copy link
Member

mhofman commented Jun 27, 2024

Describe the bug

#9563 replaced the cosmos snapshots export command to support it (#9100), but it too closely copied the height logic. Since the swing-store is not able to export a historical height, it should remove the height flags or error early if the height specified is not the latest height. Currently the export process will start and only error after the length cosmos side of the export completes.

To Reproduce

agd snapsnhots export --height $someHistoricalHeight

Expected behavior

Early error preventing historical exports
@mhofman mhofman added bug Something isn't working agoric-cosmos labels Jun 27, 2024
@mhofman mhofman self-assigned this Jun 27, 2024
@mhofman mhofman mentioned this issue Jun 27, 2024
Merged
@mergify mergify bot closed this as completed in #9601 Jun 28, 2024
@mergify mergify bot closed this as completed in 6bc363b Jun 28, 2024
mhofman added a commit that referenced this issue Jul 1, 2024
@mhofman
fix(cosmos): only allow snapshot export at latest height (#9601)
377e093 
closes: #9600

## Description
Check that an explicit height matches the latest height as exporting historical height is not supported by swing-store

### Security Considerations
None

### Scaling Considerations
None

### Documentation Considerations
Release notes should make clear limits of new support

### Testing Considerations
Manually tested explicit height

### Upgrade Considerations
Would be good to include in u16 if we cut a new rc1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mhofman mhofman

Labels
agoric-cosmos bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(cosmos): only allow snapshot export at latest height Agoric/agoric-sdk
1 participant
@mhofman