Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement kernel promise reference counting #1121

Merged
merged 3 commits into from
May 27, 2020
Merged

Implement kernel promise reference counting #1121

merged 3 commits into from
May 27, 2020

Conversation

FUDCo
Copy link
Contributor

@FUDCo FUDCo commented May 19, 2020

No description provided.

@FUDCo FUDCo added enhancement New feature or request SwingSet package: SwingSet performance Performance related issues labels May 19, 2020
@FUDCo FUDCo requested a review from warner May 19, 2020 07:41
@FUDCo FUDCo force-pushed the retire-resolved-kernel-promises branch 2 times, most recently from 15f5261 to 31c92bc Compare May 19, 2020 07:59
@FUDCo FUDCo mentioned this pull request May 21, 2020
Closed
3 tasks
warner
warner requested changes May 26, 2020
View reviewed changes
Copy link
Member

@warner warner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple of changes that need to be made, and let's double-check that the swingset unit tests are exercising the new behavior (maybe by removing some of it and making sure the tests fail)

packages/swingset-runner/src/auditstore.js Outdated Show resolved Hide resolved
packages/swingset-runner/src/auditstore.js Outdated Show resolved Hide resolved
packages/SwingSet/test/test-kernel.js Outdated Show resolved Hide resolved
packages/SwingSet/test/test-kernel.js Show resolved Hide resolved
packages/SwingSet/src/kernel/state/kernelKeeper.js Show resolved Hide resolved
packages/SwingSet/src/kernel/state/kernelKeeper.js Outdated Show resolved Hide resolved
packages/SwingSet/src/kernel/state/vatKeeper.js Show resolved Hide resolved
packages/SwingSet/src/kernel/kernel.js Outdated Show resolved Hide resolved
packages/SwingSet/src/kernel/kernel.js Outdated Show resolved Hide resolved
@FUDCo FUDCo force-pushed the retire-resolved-kernel-promises branch from 31c92bc to 25a36f0 Compare May 27, 2020 19:45
@FUDCo FUDCo merged commit a2d8a2c into master May 27, 2020
@FUDCo FUDCo deleted the retire-resolved-kernel-promises branch May 27, 2020 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@warner warner warner requested changes

Assignees
No one assigned
Labels
enhancement New feature or request performance Performance related issues SwingSet package: SwingSet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FUDCo @warner