Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WeakRef taming follows taming pattern #1931

Merged
merged 3 commits into from
Oct 27, 2020
Merged

WeakRef taming follows taming pattern #1931

merged 3 commits into from
Oct 27, 2020

Conversation

erights
Copy link
Member

@erights erights commented Oct 27, 2020

Hi @warner this is a suggested change to #1924 . Aside from these changes, #1924 LGTM

@erights erights requested a review from warner October 27, 2020 04:31
@erights erights mentioned this pull request Oct 27, 2020
Closed
warner
warner approved these changes Oct 27, 2020
View reviewed changes
Copy link
Member

@warner warner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the thorough updates.

@warner warner merged commit 3949dfb into 1872-gctools Oct 27, 2020
@warner warner deleted the gctools-delta branch October 27, 2020 06:33
@erights erights mentioned this pull request Dec 26, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@warner warner warner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erights @warner