feat(xsnap): Add Node.js shell #2169
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Dan Connolly <dckc@madmode.com> Co-authored-by: Michael Kellner <mkellner@moddable.tech> Co-authored-by: Moddable Open Source <32498429+Moddable-OpenSource@users.noreply
dckc
reviewed
Jan 8, 2021
| * @param {'ignore' | 'inherit'} [options.stdout] | ||
| * @param {'ignore' | 'inherit'} [options.stderr] | ||
| */ | ||
| export function xsnap(options) { |
There was a problem hiding this comment.
Let's please have the caller supply spawn, following ocap discipline.
See also #2160 (comment) .
There was a problem hiding this comment.
looks like getOsType is ambient too.
Perhaps not a hill I'd die on, but perhaps make platform an optional arg and add a "// Note well: AMBIENT AUTHORITY is used for convenience" comment about computing the default.
I also much prefer that module level const is only used for things that are design-time const, not things that can change at runtime. So I would prefer that getOsType were only called if the caller doesn't supply platform.
|
Smashing this into #2168 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a Node.js wrapper for controlling an
xsnapsubprocess. The package’s postinstall hook builds the debug and release binaries and is platform-agnostic (that is, it might even work on Windows), rather than locating a system level dependency.For purposes of demonstrating the controller, there is an example REPL called
src/xsrepl.jsthat is capable of taking and resuming from snapshots.Prompted by @warner to do better than having an in-XS
onMessagehook, I made the API for sending and receiving syscalls symmetric. The XS code may callsysCallor be called withanswerSysCall. The Node.js side may have ananswerSysCallimplementation and dispatches to XS with an asyncsysCallmethod. Both accept binary data and may return binary data.