Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifiable persistent deployment configuration #2613

Merged
merged 2 commits into from
Mar 10, 2021

Conversation

michaelfig
Copy link
Member

This change is just to write out the ag-setup-cosmos init configuration to deployment.json. Also allow rerunning init to modify the deployment.json.

Bonus change: upgrade the DigitalOcean default node size to 4GB RAM, which is necessary to meet system requirements.

@michaelfig michaelfig self-assigned this Mar 10, 2021
This allows new machines to be added to the network without
having to start over again.  Managing them is a different issue.
@michaelfig michaelfig force-pushed the mfig-deployment-persistent-init branch from 2e05355 to 13d6c2c Compare March 10, 2021 18:31
@michaelfig michaelfig requested a review from dckc March 10, 2021 18:32
@dckc
Copy link
Member

dckc commented Mar 10, 2021

I'm struggling to figure out which end is up... init.js seems to export doInit... which is imported from main.js... which exports main but... then the trail goes cold. I checked README.md and package.json and Makefile but I don't see how init.js gets invoked.

Also... the exported doInit closes over powerful globals, which makes me reluctant to give this an "I'm happy to maintain it" approval. ref #2160

@michaelfig
Copy link
Member Author

I'm struggling to figure out which end is up... init.js seems to export doInit... which is imported from main.js... which exports main but... then the trail goes cold. I checked README.md and package.json and Makefile but I don't see how init.js gets invoked.

The entrypoint is deployment/ag-setup-cosmos .

Also... the exported doInit closes over powerful globals, which makes me reluctant to give this an "I'm happy to maintain it" approval. ref #2160

Yeah, duly noted. This package is messy mostly because it's a glorified sysadmin script. I'm saving a major refactoring until we make a concerted effort towards ocap discipline, but there are bigger fish to fry in the more user-facing packages.

Copy link
Member

@dckc dckc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving based on understand the motivation for this change.

If you a review of the implementation details is important, you should probably dismiss this review and either (a) stand by until I find time to study it further (could be a while), (b) give me a call, or (c) get another reviewer involved.

@michaelfig michaelfig merged commit f7576e5 into master Mar 10, 2021
@michaelfig michaelfig deleted the mfig-deployment-persistent-init branch March 10, 2021 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants