Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VOM virtual object and vref weak key GC #3649

Merged
merged 11 commits into from
Oct 14, 2021
Merged

VOM virtual object and vref weak key GC #3649

merged 11 commits into from
Oct 14, 2021

Commits on Oct 14, 2021

  1. feat: VOM weak key GC

    @FUDCo
    FUDCo committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    85a79a3 View commit details
    Browse the repository at this point in the history

  2. test: update existing tests for VOM weak key gc changes

    @FUDCo
    FUDCo committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    d94e649 View commit details
    Browse the repository at this point in the history

  3. test: add tests for virtual object GC and virtual object weak keys

    @FUDCo
    FUDCo committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    cf4b983 View commit details
    Browse the repository at this point in the history

  4. test: swingset-runner demo for virtual object GC debugging

    @FUDCo
    FUDCo committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    c51ca13 View commit details
    Browse the repository at this point in the history

  5. chore: cleanups based on review comments

    @FUDCo
    FUDCo committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    47cb7c9 View commit details
    Browse the repository at this point in the history

  6. feat: GC virtual object property refs

    @FUDCo
    FUDCo committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    6dec226 View commit details
    Browse the repository at this point in the history

  7. fix: avoid GC non-determinism to be inappropriately visible

    @FUDCo
    FUDCo committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    a7248f9 View commit details
    Browse the repository at this point in the history

  8. fix: route all finalization through the possiblyDeadSet

    @FUDCo
    FUDCo committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    5d4baf6 View commit details
    Browse the repository at this point in the history

  9. fix: changes from review plus fix stochastically broken tests

    @FUDCo
    FUDCo committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    8949eb0 View commit details
    Browse the repository at this point in the history

  10. fix: correct export retirement handling and GC checks

    @FUDCo
    FUDCo committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    6eceacf View commit details
    Browse the repository at this point in the history

  11. chore(swingset): small tweaks to GC (#3968) 

    * chore(swingset): small tweaks to GC

* rename unretiredKernelRecognizableRemotables to
  kernelRecognizableRemotables , since they're all unretired
* retireOneExport: delete from kernelRecognizableRemotables even if slotToVal
  was empty. I don't think this could happen, but they're logically distinct
  checks.
* rearrange scanForDeadObjects slightly for clarity
* update comment on possibleVirtualObjectDeath
* comment on why we add globals to vatPowers
* don't completely unpack gcTools: one-off uses can dereference directly, to
  let the unpack fit in a single line

refs #3732

* fix: revert retireOneExport handling of kernelRecognizableRemotables

I'm still uncertain that this is the right way to go, but we're going to
leave this as-is and revisit it later.
    @warner @FUDCo
    warner authored and FUDCo committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    db24b39 View commit details
    Browse the repository at this point in the history