Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(xsnap): round-trip byte sequences from Golang for dynamic IBC #3813

Merged
merged 1 commit into from
Sep 10, 2021

Conversation

michaelfig
Copy link
Member

refs: #2118

This satisfies my requirements for IBC binaries built from strings containing \x00 etc.

@dckc, please let me know if the two other tests taken from your PR #3156 are still desirable.

@michaelfig michaelfig added the xsnap the XS execution tool label Sep 10, 2021
@michaelfig michaelfig self-assigned this Sep 10, 2021
packages/xsnap/test/test-xsnap.js Outdated Show resolved Hide resolved
packages/xsnap/test/test-xsnap.js Outdated Show resolved Hide resolved
packages/xsnap/test/test-xsnap.js Outdated Show resolved Hide resolved
Copy link
Member

@dckc dckc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for polishing this off!

@michaelfig michaelfig merged commit 29fad0f into master Sep 10, 2021
@michaelfig michaelfig deleted the 2118-xs-ibc-str-test branch September 10, 2021 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
xsnap the XS execution tool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants