Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(swingset): force GC on more intermittently-failing tests #4961

Merged
merged 1 commit into from
Mar 31, 2022

Conversation

warner
Copy link
Member

@warner warner commented Mar 30, 2022

The previous PR didn't go far enough, there are other tests in the
same file that are still failing intermittently. This turns on the
forceGC flag on all tests in test-virtualObjectGC.js

refs #4936

@warner warner added the SwingSet package: SwingSet label Mar 30, 2022
@warner warner requested a review from FUDCo as a code owner March 30, 2022 06:13
@warner warner self-assigned this Mar 30, 2022
Copy link
Contributor

@FUDCo FUDCo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The things we do for love.

@warner warner added the automerge:rebase Automatically rebase updates, then merge label Mar 31, 2022
The previous PR didn't go far enough, there are other tests in the
same file that are still failing intermittently. This turns on the
forceGC flag on *all* tests in test-virtualObjectGC.js

refs #4936
@mergify mergify bot merged commit 1de2e41 into master Mar 31, 2022
@mergify mergify bot deleted the 4936-force-more-gc branch March 31, 2022 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge:rebase Automatically rebase updates, then merge SwingSet package: SwingSet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants