feat(web-components): read purses from bank instead of smart wallet #6861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turadg
approved these changes
Jan 26, 2023
I think for the effort to be worth the value we'd want e2e tests with a real local chain running. We could also just mock the queryclient or the follower to return the type of data we expect, but I don't know how much safer that makes us feel. |
|
Mocking the query client would be great, I think. |
dckc
reviewed
Jan 27, 2023
| * @param {string} address | ||
| * @param {string} rpc | ||
| */ | ||
| export const queryBankBalances = async (address, rpc) => { |
There was a problem hiding this comment.
another copy of this? same scaling consideration applies. Filed:
dckc
reviewed
Jan 27, 2023
| const rpcClient = createProtobufRpcClient(queryClient); | ||
| const bankQueryService = new QueryClientImpl(rpcClient); | ||
|
|
||
| const { balances } = await bankQueryService.AllBalances({ |
There was a problem hiding this comment.
ambient authority concern applies here too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs Agoric/wallet-app#49
For now the dapps only care about vbank assets so we can enhance this at a later point to include pure-js purses as well.