Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(cosmos): create build wrapper in bin/agd #7037

Merged
merged 6 commits into from
Mar 17, 2023
Merged

build(cosmos): create build wrapper in bin/agd #7037

merged 6 commits into from
Mar 17, 2023

Conversation

michaelfig
Copy link
Member

@michaelfig michaelfig commented Feb 20, 2023 •
edited
Loading

refs: #7052, #7053

Description

Enables cosmovisor support for the SDK, given:

  1. validators install and use our patched cosmovisor (feat: Enhance Cosmovisor for Github zip archives agoric-labs/cosmos-sdk#295) via go install -v github.com/agoric-labs/cosmos-sdk/cosmovisor/cmd/cosmovisor@Agoric
  2. an upgrade proposal naming a zip file of the desired Agoric SDK: `agd tx gov submit-proposal software-upgrade --upgrade-info='{"binaries":{"any":"https://github.com/Agoric/agoric-sdk/archive/c1a98c6fe3ab86cfc4101ceac175e57b174e6dca.zip?checksum=sha256:bf1a4f71ee4016ebf5687cb5ccd0cc52fe8b0708f74457142550be8dabb7abac"}}'

Security Considerations

Scaling Considerations

Documentation Considerations

Testing Considerations

@michaelfig michaelfig force-pushed the mfig-agd-build branch 15 times, most recently from a6dc881 to 5d9c1ba Compare February 25, 2023 02:17
@michaelfig michaelfig mentioned this pull request Feb 25, 2023
Closed
@michaelfig michaelfig marked this pull request as ready for review February 25, 2023 02:21
@michaelfig michaelfig self-assigned this Feb 25, 2023
@michaelfig michaelfig force-pushed the mfig-agd-build branch 3 times, most recently from 39bd09e to d7e047c Compare February 25, 2023 03:37
mhofman
mhofman reviewed Feb 25, 2023
View reviewed changes
Copy link
Member

@mhofman mhofman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have to admit this is a little outside my wheelhouse. I'll try to take a closer look later, but I feel I'm not the best person to review this.

packages/xsnap/build.env
@@ -0,0 +1,4 @@
MODDABLE_URL=https://github.com/agoric-labs/moddable.git
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have seen this file show up dirty on my environment, and I think is a consequence of https://github.com/Agoric/agoric-sdk/pull/7048/files#r1117951126

But here I suppose you're taking advantage of this to rebuild?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This issue should now be fixed. build.env is checked into Git for this PR.

@dckc dckc mentioned this pull request Feb 27, 2023
Closed
1 task
JimLarson
JimLarson approved these changes Mar 17, 2023
View reviewed changes
bin/agd
# shellcheck disable=SC1091
source "$thisdir/../repoconfig.sh"

if test "${1-''}" = build; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please give a synopsis of the expected args, ideally as a usage() function that prints it on arg parsing errors.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added more help text to the top of the file. Determining arg parsing errors is tricky, because we accept all the options that agd does, but now I've made that clearer.

@michaelfig michaelfig added the automerge:no-update (expert!) Automatically merge without updates label Mar 17, 2023
@datadog-full-agoric
Copy link

datadog-full-agoric bot commented Mar 17, 2023 •
edited
Loading

Datadog Report

Branch report: mfig-agd-build
Commit report: 0d5f50b

✅ agoric-sdk: 0 Failed, 0 New Flaky, 3758 Passed, 53 Skipped, 14m 33.14s Wall Time

@michaelfig michaelfig added the force:integration Force integration tests to run on PR label Mar 17, 2023
@michaelfig michaelfig force-pushed the mfig-agd-build branch 4 times, most recently from d6147bc to d61e646 Compare March 17, 2023 20:38
@mergify mergify bot merged commit 1613dc0 into master Mar 17, 2023
@mergify mergify bot deleted the mfig-agd-build branch March 17, 2023 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhofman mhofman mhofman left review comments

@JimLarson JimLarson JimLarson approved these changes

@arirubinstein arirubinstein Awaiting requested review from arirubinstein

Assignees

@michaelfig michaelfig

Labels
automerge:no-update (expert!) Automatically merge without updates force:integration Force integration tests to run on PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michaelfig @mhofman @JimLarson