Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor startXSnap #7235

Merged
merged 8 commits into from
Mar 24, 2023
Merged

refactor startXSnap #7235

merged 8 commits into from
Mar 24, 2023

Conversation

warner
Copy link
Member

@warner warner commented Mar 24, 2023

perform some internal refactorings to make upcoming changes simpler

  • make initializeKernel async, so it can wait for xsnap bundles in record worker bundleIDs in vat metadata, use during reload #7208
  • move makeStartXSnap out to a separate file, simplify it
  • pass specific options/flags into makeStartXSnap, instead of the whole environment
  • then make env processing the responsibility of the caller

@warner warner added the SwingSet package: SwingSet label Mar 24, 2023
@warner warner requested a review from gibson042 March 24, 2023 00:51
@warner warner self-assigned this Mar 24, 2023
@codecov
Copy link

codecov bot commented Mar 24, 2023

Codecov Report

Merging #7235 (9b5dff0) into master (33ffd7b) will decrease coverage by 8.72%.
The diff coverage is 85.45%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7235      +/-   ##
==========================================
- Coverage   79.27%   70.56%   -8.72%     
==========================================
  Files         393      447      +54     
  Lines       74434    85167   +10733     
  Branches        3        3              
==========================================
+ Hits        59011    60099    +1088     
- Misses      15422    25000    +9578     
- Partials        1       68      +67     
Impacted Files Coverage Δ
packages/SwingSet/src/controller/startXSnap.js 83.15% <83.15%> (ø)
packages/SwingSet/src/controller/controller.js 98.32% <100.00%> (+1.89%) ⬆️
...ckages/SwingSet/src/controller/initializeKernel.js 99.10% <100.00%> (+0.02%) ⬆️
...ages/SwingSet/src/controller/initializeSwingset.js 95.00% <100.00%> (+0.03%) ⬆️

... and 54 files with indirect coverage changes

Impacted file tree graph

@datadog-full-agoric
Copy link

datadog-full-agoric bot commented Mar 24, 2023

Datadog Report

Branch report: refactor-start-xsnap
Commit report: a165f71

agoric-sdk: 0 Failed, 0 New Flaky, 3806 Passed, 57 Skipped, 25m 43.15s Wall Time

Copy link
Member

@gibson042 gibson042 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a reasonable refactoring. I like the movement of makeStartXSnap to its own file.

packages/SwingSet/src/controller/startXSnap.js Outdated Show resolved Hide resolved
packages/SwingSet/src/controller/startXSnap.js Outdated Show resolved Hide resolved
packages/SwingSet/src/controller/startXSnap.js Outdated Show resolved Hide resolved
packages/SwingSet/src/controller/startXSnap.js Outdated Show resolved Hide resolved
@warner warner added the automerge:rebase Automatically rebase updates, then merge label Mar 24, 2023
@mergify mergify bot merged commit 7a6e197 into master Mar 24, 2023
@mergify mergify bot deleted the refactor-start-xsnap branch March 24, 2023 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge:rebase Automatically rebase updates, then merge SwingSet package: SwingSet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants