-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor startXSnap #7235
refactor startXSnap #7235
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #7235 +/- ##
==========================================
- Coverage 79.27% 70.56% -8.72%
==========================================
Files 393 447 +54
Lines 74434 85167 +10733
Branches 3 3
==========================================
+ Hits 59011 60099 +1088
- Misses 15422 25000 +9578
- Partials 1 68 +67
|
Datadog ReportBranch report: ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a reasonable refactoring. I like the movement of makeStartXSnap
to its own file.
so test vats can import E/Far from @endo/far instead of pulling in all of @endo/marshal
Minor refactoring of `makeStartXSnap` to inline as much as possible
4e65c17
to
9b5dff0
Compare
perform some internal refactorings to make upcoming changes simpler
initializeKernel
async, so it can wait for xsnap bundles in record worker bundleIDs in vat metadata, use during reload #7208makeStartXSnap
out to a separate file, simplify itmakeStartXSnap
, instead of the whole environmentenv
processing the responsibility of the caller