Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: more usable bidding CLI: integrated sign/broadcast #7256

Merged
merged 18 commits into from
Apr 5, 2023
Merged

feat: more usable bidding CLI: integrated sign/broadcast #7256

merged 18 commits into from
Apr 5, 2023

Commits on Apr 5, 2023

  1. fix(agoric-cli): handle agd not in $PATH

    @dckc
    dckc committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    3ad7887 View commit details
    Browse the repository at this point in the history

  2. feat(agoric-cli): inter bid cancel

    @dckc
    dckc committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    684a2a3 View commit details
    Browse the repository at this point in the history

  3. feat: AGORIC_KEYRING_BACKGROUND convenience 

    because --keyring-backend=test gets boring
    @dckc
    dckc committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    89ae6c5 View commit details
    Browse the repository at this point in the history

  4. feat!: UX for inter bid 

    BREAKING CHANGE: --giveCurrency option becomes --give and likewise
--wantCollateral -> --want. Use snake-case for options throughout to
match cosmos-sdk style

 - `bid` commands integrate `wallet send` step
   - show bid result
 - use only liveOffers for inter bid list by default
   - to show all: --all
 - fix: provide --allow-spend for tryExitOffer
   unless/until we change the wallet contract
 - don't show redundant result in error case
 - trial: use offer safe want in by-price bids
 - leave exit onDemand implicit
 - refactor:
   - factor out outputActionAndHint
   - allow explicit io for execSwingsetTransaction
     - combine options into one object
   - factor out storedWalletState
   - factor pollBlocks out of pollTx
 - update tests

feat: inter bid by-discount sends; --generate-only; list --all

 - bid by-discount, like by-price, sends the tx
   - factor out placeBid, SharedBidOpts, withSharedBidOptions
 - bid list uses activeOffers unless --all is given
 - support --generate-only
 - use snake-case for option names; avoid [xx] optional syntax
 - give PATH clue everywhere execFileSync is used
 - test.todo()s
 - code polish:
   - expand file, function docs
   - refactor: hoist bidInvitationShape
    @dckc
    dckc committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    52d93c3 View commit details
    Browse the repository at this point in the history

  5. feat: inter vbank list: expose denom, boardId, decimalPlaces

    @dckc
    dckc committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    f4fb840 View commit details
    Browse the repository at this point in the history

  6. chore: agops inter reserve add -> agops reserve add 

     - chore: bid "want" is required but different from proposal.want
    @dckc
    dckc committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    b833ba1 View commit details
    Browse the repository at this point in the history

  7. feat: agops auction proposeParamChange

    @dckc
    dckc committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    f9e1f80 View commit details
    Browse the repository at this point in the history

  8. feat: agops ec: integrated sign, broadcast, await 

     - docs: normalizeAddress: keyring type tweak
    @dckc
    dckc committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    e13cf6c View commit details
    Browse the repository at this point in the history

  9. refactor: isolate outdated terminology

    @dckc
    dckc committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    6b27b87 View commit details
    Browse the repository at this point in the history

  10. docs(agoric-cli): sketch POLA re-org for threading I/O powers

    @dckc
    dckc committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    6e8a18a View commit details
    Browse the repository at this point in the history

  11. chore: postpone async clock(); just use now()

    @dckc
    dckc committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    a4d0256 View commit details
    Browse the repository at this point in the history

  12. refactor: move storedWalletState, pollOffer to lib/wallet.js

    @dckc
    dckc committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    a3cde50 View commit details
    Browse the repository at this point in the history

  13. chore: Bid offer maker takes desiredBuy, wantMinimum

    @dckc
    dckc committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    ab40c8c View commit details
    Browse the repository at this point in the history

  14. chore: Offers.auction.Bid takes string amounts and a parser

    @dckc
    dckc committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    ef7dca1 View commit details
    Browse the repository at this point in the history

  15. chore: inter bid: amount args: --give 5 -> --give 5IST

    @dckc
    dckc committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    d743e58 View commit details
    Browse the repository at this point in the history

  16. docs: note 1st arg of Offers.auction.Bid is odd

    @dckc
    dckc committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    87d951d View commit details
    Browse the repository at this point in the history

  17. chore: Bid WIP

    @dckc
    dckc committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    9b2c384 View commit details
    Browse the repository at this point in the history

  18. build(inter-protocol): sync verion of agoric pkg

    @dckc
    dckc committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    1200ad5 View commit details
    Browse the repository at this point in the history