feat: separate vaults launch from platform #7563
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turadg
reviewed
May 1, 2023
| if (e.code !== 'ENOENT') { | ||
| throw e; | ||
| } | ||
| // FIXME: We could take a hard dependency on `tmp` here, but is it worth it? |
There was a problem hiding this comment.
probably not worth the NPM dependency but we do have Node and could use mkdtemp
There was a problem hiding this comment.
that file isn't actually in this PR; it's an artifact of stacking this on mfig-cli-run-no-solo
| @@ -355,7 +355,7 @@ export const startRewardDistributor = async ({ | |||
| bankManager, | |||
| vaultFactoryKit, | |||
| periodicFeeCollectors, | |||
| stakeFactoryKit, | |||
| // stakeFactoryKit, | |||
| /** | ||
| * Introduce charter to governed creator facets. | ||
| * | ||
| * XXX make this the responsibility of startVaultFactory, startReserve, etc.? |
| return { permit, script, bundles }; | ||
| }; | ||
|
|
||
| test.serial('make vaults launch proposal', async t => { |
michaelfig
reviewed
May 2, 2023
| @@ -171,13 +171,13 @@ export const makeBootstrap = ( | |||
| const { root } = vat; | |||
| const decodedArgs = args.map(decodePassable); | |||
| const result = await E(root)[methodName](...decodedArgs); | |||
| return encodePassable(result); | |||
| return encodePassable(harden(result)); | |||
3 tasks
usually among installations
sort of papers over lack of harden() around some start results and lack of good stack traces to figure out which one
redundant with another branch?
In packages/vats, run: yarn test test/bootstrapTests/test-inter-launch.js
other cleanup
|
Updated the PR with some cleanups around proposal builder, installing the ATOM collateral, measuring per crank computrons. All tests pass, but the PR still needs some rebasing / fixups as I mostly kept the original WIP commits. |
Merged
|
@mhofman thanks for polishing this up, but as noted in #5819 (comment) , this is no longer the plan. If you added anything along the way that should be kept, please put it in another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #5819 (or at least: refs)
The code still needs some rebasing / fixup, but I works.
@warner do you want to review this? feel free to take yourself out of the list.
Description
remove vaults proposal from devnet bootstrap config
take governance committee, oracles, out of vaults proposal
take stakeFactory out of vaults proposal
add initial collateral type
prune dead code from
packages/inter-protocol/scripts/init-core.js,packages/inter-protocol/src/proposals/core-proposal.jsreview install Inter protocol defi contracts after boostrap using publishBundle #5819 etc. for configuration details to take care of
Security Considerations
nothing new, I don't think
Scaling Considerations
Documentation Considerations
The proposal to launch vaults should come with a community discussion post.
See also
Testing Considerations
TODO: