fix: handle missing schedule fields in inter auction status
#7787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turadg
approved these changes
May 18, 2023
michaelfig
approved these changes
May 18, 2023
dckc
force-pushed
the
7786-auction-status-fix
branch
from
0421a40
to
d23c5a0
Compare
|
bleah... I did the changes while on a different branch and neglected to cherry-pick the test refactor when I moved it to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #7786
Description
Update
inter auction statusto handle the change to optional fields in e893e0e.Oddly, that commit is marked as a refactor, but also marked as closing a bug. #7786 shows that it's a also breaking change of sorts.
Security / Scaling Considerations
n/a
Documentation Considerations
addressed a tsc
anyfallback problem (cf. #6512) that made #7786 statically evident.Testing Considerations
added a unit test