build: clean up notifier deps #7921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelfig
approved these changes
Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While working on #6591 I noticed that even
yarn installof those simple web components was causingbetter-sqlite3to build. The only @Agoric package they import was notifier. That declared a runtime dependency on swingset-store, but it was only needed for tests.This cleans up the dependency declarations of @agoric/notifier to lighten the downstream dependencies.
It also fixes a second problem, with swingset-vats exporting a test helper that depends on a tool from swingset-liveslots that's not published.
Security Considerations
Scaling Considerations
Documentation Considerations
Testing Considerations