ci(getting-started): run (but ignore) checks with `npm` and `npx` #8250

michaelfig · 2023-08-24T19:02:55Z

Description

Begin testing the getting started instructions using npm install -g agoric and npx agoric ....

This currently fails because of an incompatibility with @endo/bundle-source@2.5.2's dependency on a patched version of Rollup downloaded from https://github.com/endojs/endo, which causes a problem when NPM autoruns its prepare script.

So, continue-on-error just because those combinations are currently failing.

@kriskowal the next (after 2023-08-23) Endo release will solve the problem when it is used in Agoric SDK.

Security Considerations

n/a

Scaling Considerations

n/a

Documentation Considerations

Allows updating our Getting Started instructions with new possibilities for obtaining the Agoric CLI:

current git clone -b community-dev https://github.com/Agoric/agoric-sdk && cd agoric-sdk && yarn install && yarn build && yarn create-agoric-cli /usr/local/bin/agoric
yarn global add agoric@community-dev
npm install -g agoric@community-dev
alias agoric="npx agoric@community-dev"

Testing Considerations

Requires attention to the next Endo merge.

Upgrade Considerations

n/a

kriskowal · 2023-08-24T20:45:00Z

We added a mention to check for issues with the next release label during the release process but I see that it seems to have been removed. In any case, I’ll try to remember this change.

erights · 2023-08-27T22:01:19Z

Requires attention to the next Endo merge.

Hi @michaelfig , could you spin off a minimally different copy of this PR with your #endo-branch: master directive so we can see how compat it already is with endo master, and what the remaining problems are? Thanks.

patches/@lerna+version+5.6.2.patch

turadg

Approving contingent on the simpler Lerna patch

turadg · 2023-08-28T21:16:28Z

.github/workflows/integration.yml

@@ -29,7 +29,7 @@ jobs:
    runs-on: ubuntu-latest
    strategy:
      matrix:
-        cli: [link-cli, local-npm]
+        cli: [link-cli, local-npm, local-npm/npm, local-npm/npx]


Suggested change

cli: [link-cli, local-npm, local-npm/npm, local-npm/npx]

cli: [link-cli/yarn, registry/yarn, registry/npm, registry/npx]

😄

packages/deployment/package.json

turadg · 2023-08-28T21:20:23Z

packages/inter-protocol/package.json

@@ -63,7 +63,6 @@
    "import-meta-resolve": "^2.2.1"
  },
  "files": [
-    "bundles",


@dckc and I have talked about publishing bundles but haven't though through it fully.

(@michaelfig mentioned that including it here adds 20MB, making it too big for repos that have a limit, like verdaccio at 10MB)

patches/@lerna+version+5.6.2.patch

scripts/local-npm.sh

turadg · 2023-08-28T21:28:52Z

scripts/local-npm.sh

+  test -z "${LOCAL_NPM_HOME-}" || export HOME="$LOCAL_NPM_HOME"
+  test -z "${LOCAL_NPM_DISTTAG-}" || export DISTTAG="$LOCAL_NPM_DISTTAG"


not clear to me why not: HOME = HOME || LOCAL_NPM_HOME.

I actually want LOCAL_NPM_HOME && (HOME=LOCAL_NPM_HOME) but I can't find a more concise way to write it.

michaelfig · 2023-08-29T00:09:41Z

could you spin off a minimally different copy of this PR with your #endo-branch: master directive so we can see how compat it already is with endo master, and what the remaining problems are? Thanks.

@mhofman and I are working on getting the nightly scheduled test against master to green, and it will notify us when there is breakage. I'll send you subscription instructions out-of-band, if that's something you're interested in.

mhofman · 2023-08-29T17:30:07Z

@Mergifyio requeue main

mhofman · 2023-08-29T17:31:01Z

@Mergifyio refresh

mergify · 2023-08-29T17:31:33Z

requeue main

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

mergify · 2023-08-29T17:31:34Z

refresh

✅ Pull request refreshed

mhofman · 2023-08-29T17:31:43Z

@Mergifyio queue main

mergify · 2023-08-29T17:31:52Z

queue main

✅ The pull request has been merged automatically

The pull request has been merged automatically at 3ce0599

michaelfig self-assigned this Aug 24, 2023

michaelfig added agoric-cli package: agoric-cli tooling repo-wide infrastructure force:integration Force integration tests to run on PR labels Aug 24, 2023

michaelfig force-pushed the mfig-ci-npx branch 8 times, most recently from f1c1b54 to ccd9c6a Compare August 25, 2023 22:26

michaelfig marked this pull request as ready for review August 27, 2023 18:45

michaelfig requested review from turadg and mhofman August 27, 2023 18:46

michaelfig force-pushed the mfig-ci-npx branch from ccd9c6a to c0ff62e Compare August 27, 2023 19:07

michaelfig mentioned this pull request Aug 27, 2023

ci: combine integration tests #8253

Merged

erights reviewed Aug 27, 2023

View reviewed changes

patches/@lerna+version+5.6.2.patch Outdated Show resolved Hide resolved

turadg approved these changes Aug 28, 2023

View reviewed changes

michaelfig force-pushed the mfig-ci-npx branch from c0ff62e to 1ac702a Compare August 29, 2023 00:37

michaelfig added 7 commits August 29, 2023 09:51

ci(getting-started): run (but ignore) checks with npm and npx

82ca746

chore(deployment): properly set packageJson.name

a59b935

ci(getting-started): break out registry.sh

7934260

chore: patch lerna for prettier removing resolveConfig.sync

ce1235f

chore(builders): add missing tsconfig.build

4daee1a

chore: add empty CHANGELOG.md files

dd6a214

chore(inter-protocol): do not publish bundles to NPM

dd2873d

michaelfig force-pushed the mfig-ci-npx branch from 1ac702a to dd2873d Compare August 29, 2023 15:55

michaelfig added the automerge:no-update (expert!) Automatically merge without updates label Aug 29, 2023

mergify bot merged commit 3ce0599 into master Aug 29, 2023
78 of 83 checks passed

mergify bot deleted the mfig-ci-npx branch August 29, 2023 17:31

mhofman mentioned this pull request Aug 29, 2023

ci: only satisfy pre-checks once merge requested #8275

Merged

mhofman mentioned this pull request Sep 21, 2023

Publishable NPM packages for mainnet #8360

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ci(getting-started): run (but ignore) checks with `npm` and `npx` #8250

ci(getting-started): run (but ignore) checks with `npm` and `npx` #8250

michaelfig commented Aug 24, 2023 •

edited

Loading

kriskowal commented Aug 24, 2023

erights commented Aug 27, 2023

turadg left a comment

turadg Aug 28, 2023

turadg Aug 28, 2023

turadg Aug 28, 2023

michaelfig Aug 29, 2023

michaelfig commented Aug 29, 2023

mhofman commented Aug 29, 2023

mhofman commented Aug 29, 2023

mergify bot commented Aug 29, 2023

mergify bot commented Aug 29, 2023

mhofman commented Aug 29, 2023

mergify bot commented Aug 29, 2023

	cli: [link-cli, local-npm, local-npm/npm, local-npm/npx]
	cli: [link-cli/yarn, registry/yarn, registry/npm, registry/npx]

		test -z "${LOCAL_NPM_HOME-}" \|\| export HOME="$LOCAL_NPM_HOME"
		test -z "${LOCAL_NPM_DISTTAG-}" \|\| export DISTTAG="$LOCAL_NPM_DISTTAG"

ci(getting-started): run (but ignore) checks with npm and npx #8250

ci(getting-started): run (but ignore) checks with npm and npx #8250

Conversation

michaelfig commented Aug 24, 2023 • edited Loading

Description

Security Considerations

Scaling Considerations

Documentation Considerations

Testing Considerations

Upgrade Considerations

kriskowal commented Aug 24, 2023

erights commented Aug 27, 2023

turadg left a comment

Choose a reason for hiding this comment

turadg Aug 28, 2023

Choose a reason for hiding this comment

turadg Aug 28, 2023

Choose a reason for hiding this comment

turadg Aug 28, 2023

Choose a reason for hiding this comment

michaelfig Aug 29, 2023

Choose a reason for hiding this comment

michaelfig commented Aug 29, 2023

mhofman commented Aug 29, 2023

mhofman commented Aug 29, 2023

mergify bot commented Aug 29, 2023

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

mergify bot commented Aug 29, 2023

✅ Pull request refreshed

mhofman commented Aug 29, 2023

mergify bot commented Aug 29, 2023

✅ The pull request has been merged automatically

ci(getting-started): run (but ignore) checks with `npm` and `npx` #8250

ci(getting-started): run (but ignore) checks with `npm` and `npx` #8250

michaelfig commented Aug 24, 2023 •

edited

Loading