move priceAuthorityRegistry with its vat #8717
Conversation
turadg
changed the title
There was a problem hiding this comment.
I defer approval to @Chris-Hibbert ; I think he's more swapped in on how to slice up the zoe package.
| import { PriceAuthorityI } from '../src/contractSupport/priceAuthority.js'; | ||
| import { PriceAuthorityI } from '@agoric/zoe/src/contractSupport/priceAuthority.js'; |
There was a problem hiding this comment.
So the registry moves but not the priceAuthority API itself? OK.
It has always seemed strange to me that Price Authority docs are under zoe, but whatever.
There was a problem hiding this comment.
The plan for deploying this change to production is the general "upgrade all vats" I suppose (#8104 -ish)
There was a problem hiding this comment.
So the registry moves but not the priceAuthority API itself?
Regardless of where the priceAuthority API (and doc) winds up, the priceAuthorityRegistry reasonably belongs with the vat that its deployed in.
| import { PriceAuthorityI } from '../src/contractSupport/priceAuthority.js'; | ||
| import { PriceAuthorityI } from '@agoric/zoe/src/contractSupport/priceAuthority.js'; |
There was a problem hiding this comment.
So the registry moves but not the priceAuthority API itself?
Regardless of where the priceAuthority API (and doc) winds up, the priceAuthorityRegistry reasonably belongs with the vat that its deployed in.
| import { providePriceAuthorityRegistry } from '../../../tools/priceAuthorityRegistry.js'; | ||
| import { makeFakePriceAuthority } from '../../../tools/fakePriceAuthority.js'; | ||
| import { providePriceAuthorityRegistry } from '../src/priceAuthorityRegistry.js'; | ||
| import { makeFakePriceAuthority } from '../../zoe/tools/fakePriceAuthority.js'; |
There was a problem hiding this comment.
any reason to not import from @agoric/zoe? lint-primary is showing cross-package import as an error.
turadg
force-pushed
the
ta/move-priceAuthorityRegistry
branch
2 times, most recently
from
6b30e98
to
b70c02f
Compare
|
@turadg - This PR appears to be stuck. It's had a merge label for > 24 hours |
turadg
force-pushed
the
ta/move-priceAuthorityRegistry
branch
from
b70c02f
to
bf8a982
Compare
Somewhat of a breaking change but it's moving from tools which is not part of the package API
turadg
force-pushed
the
ta/move-priceAuthorityRegistry
branch
from
bf8a982
to
a92cf55
Compare
refs: #7399 (comment)
Description
priceAuthorityRegistry is in the Zoe package but it's the implementation of
vat-priceAuthorityRegistry. This moves it adjacent to the latter.It also has a misc typedef improvement that happened to be on my working branch.
Security Considerations
Scaling Considerations
Documentation Considerations
Testing Considerations
Upgrade Considerations
This removes a file from the
@agoric/zoepackage, but it's intoolswhich is not part of the package API. So I didn't call it a breaking change. Also if I had used conventional commits to mark it a breaking change, it would have been called a breaking change to@agoric/vatstoo, which would be erroneous. One more reason to stop using conventional commits, imo.