fix: update protobuf download and generation for ibc-go v4 #8769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelfig
approved these changes
Jan 18, 2024
michaelfig
added
automerge:rebase
mhofman
pushed a commit
that referenced
this pull request
Feb 7, 2024
fix: update protobuf download and generation for ibc-go v4
mhofman
pushed a commit
that referenced
this pull request
Feb 7, 2024
fix: update protobuf download and generation for ibc-go v4
mhofman
pushed a commit
that referenced
this pull request
Feb 18, 2024
fix: update protobuf download and generation for ibc-go v4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #8767
Description
Update our proto dependency fetching for new dependencies.
Update some generation details to match ibc-go machinery.
Update dependencies and regenerate
.pb.gofiles. No change in these files, but previously hand-edited code is not generated correctly.Clean up unused junk in
Makefile.Security Considerations
New dependency, but only for proto files.
Scaling Considerations
N/A
Documentation Considerations
N/A
Testing Considerations
N/A
Upgrade Considerations
N/A