golangci lint fix #8971
Merged
golangci lint fix #8971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #8974
refs: #XXXX
Description
Update agoric golang code to address deprecation warnings introduced in v46 SDK update.
gh.neting.cc.cosmos.cosmos-sdk.types.errors.WrapXXXbecomescosmossdk.io.errors.WrapXXXgh.neting.cc.cosmos.cosmos-sdk.types.Uintbecomescosmossdk.io.math.UintThese deprecation lint checks were made non-fatal in Tolerate
golangci-lintdeprecation errors #8866Introduce
make lintingolang/cosmos/Remove CI directives to skip treating deprecations as failures.
Security Considerations
None. The code should be functionally equivalent before & after the fix, thus introducing no new security concerns.
Scaling Considerations
None. The code should be functionally equivalent before & after the fix, thus introducing no new scaling concerns.
Test Plan
Tested via CI.
Upgrade Considerations
Needs a chain halting upgrade.