chore: clean up dead code for legacy REST methods #9091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RegisterRESTRoutes has been removed from the AppModuleBasic interface.
JimLarson
force-pushed
the
8803-legacy-rest
branch
from
135d133 to
09528fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #8803
Description
Cosmos-SDK 0.46 removed the "legacy REST" interface in cosmos/cosmos-sdk#9594. The supporting
RegisterRESTRoutes()method was left in theAppModuleBasicinterface for "compatibility" (?), but was finally removed in cosmos/cosmos-sdk#11797.We have several no-op implementations of this method that are no longer required for compilation. Cleaning them up reduces clutter.
Security Considerations
None.
Scaling Considerations
None.
Documentation Considerations
None.
Testing Considerations
None.
Upgrade Considerations
None.