Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: typedoc markdown #9146

Merged
merged 7 commits into from
Mar 27, 2024
Merged

chore: typedoc markdown #9146

merged 7 commits into from
Mar 27, 2024

Conversation

LuqiPan
Copy link
Contributor

@LuqiPan LuqiPan commented Mar 26, 2024

closes: #XXXX
refs: Agoric/documentation#927

Description

Similar to endojs/endo#2185, this PR addresses comment errors in agoric-sdk repo

Security Considerations

Scaling Considerations

Documentation Considerations

This is one of the blockers for Agoric/documentation#927

Testing Considerations

Upgrade Considerations

@LuqiPan LuqiPan requested review from turadg and dckc March 26, 2024 21:52
package.json Outdated
@@ -69,6 +70,7 @@
"clean": "yarn lerna run --no-bail clean",
"check-dependencies": "node ./scripts/check-mismatched-dependencies.cjs",
"docs": "typedoc --tsconfig tsconfig.build.json",
"typedoc-markdown": "typedoc --plugin typedoc-plugin-markdown",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same questions as in the other PR.

plus: why doesn't it need the tsconfig.build.json ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call! Updating both PRs to use tsconfig.build.json now...

@LuqiPan LuqiPan changed the title 927 typedoc markdown chore: typedoc markdown Mar 26, 2024
@LuqiPan LuqiPan added the automerge:squash Automatically squash merge label Mar 26, 2024
@LuqiPan LuqiPan requested a review from turadg March 27, 2024 00:06
@dckc
Copy link
Member

dckc commented Mar 27, 2024

signature verification failed in install-bundle in integration test

I'm not sure what's up with this...

+ agd tx swingset install-bundle --compress @/root/.agoric/cache/b1-8543f5a3d7bf1a68d0a7b4a03521c673882468c08885e69ede4eca03d85aa05093285d1c8f31dbcbfdf298ae6c6826223a8821119eff15e77663ed86c6446e48.json --from user1 --keyring-backend=test --gas=auto --gas-adjustment=1.2 --chain-id=agoriclocal -bblock --yes -o json
gas estimate: 50468550
{"height":"0","txhash":"0672E28C92D59C7CEDEBA4F6454B67200764801E17D2BA2C0229E8B8DA5E0004","codespace":"sdk","code":4,"data":"","raw_log":"signature verification failed; please verify account number (0) and chain-id (): unauthorized","logs":[],"info":"","gas_wanted":"0","gas_used":"3384243","tx":null,"timestamp":"","events":[]}

https://github.com/Agoric/agoric-sdk/actions/runs/8444690656/job/23130694007?pr=9146#step:7:867

@mergify mergify bot merged commit 8e87d58 into master Mar 27, 2024
66 checks passed
@mergify mergify bot deleted the 927-typedoc-markdown branch March 27, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge:squash Automatically squash merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants