9207 orchestrator stub #9208
Merged
9207 orchestrator stub #9208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xpatrickdev
force-pushed
the
8881-ica-send-message
branch
2 times, most recently
from
38c7bc3
to
54d830f
Compare
turadg
force-pushed
the
9207-orchestrator-stub
branch
from
daca3e1
to
ba53d21
Compare
turadg
force-pushed
the
9207-orchestrator-stub
branch
from
ba53d21
to
ba700c3
Compare
Deploying agoric-sdk with
|
| Latest commit: |
1e054ac
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5f2979f4.agoric-sdk.pages.dev |
| Branch Preview URL: | https://9207-orchestrator-stub.agoric-sdk.pages.dev |
turadg
force-pushed
the
9207-orchestrator-stub
branch
2 times, most recently
from
e449107
to
f808615
Compare
0xpatrickdev
approved these changes
Apr 24, 2024
| /** | ||
| * Submit a transaction on behalf of the remote accoutn for execution on teh remote chain. |
There was a problem hiding this comment.
Suggested change
| * Submit a transaction on behalf of the remote accoutn for execution on teh remote chain. | |
| * Submit a transaction on behalf of the remote account for execution on the remote chain. |
| @@ -93,6 +93,8 @@ export const prepareStakingAccountHolder = (baggage, makeRecorderKit, zcf) => { | |||
| getUpdater() { | |||
| return this.state.topicKit.recorder; | |||
| }, | |||
| // TODO move this beneath the Orchestration abstraction, | |||
| // to the OrchestrationAccount provided by makeAccount() | |||
There was a problem hiding this comment.
Suggested change
| // to the OrchestrationAccount provided by makeAccount() | |
| // to the OrchestrationAccount provided by createAccount() |
| @@ -0,0 +1,102 @@ | |||
| // @ts-check | |||
There was a problem hiding this comment.
I think whatever we do should be consistent across the repository. I'm going to leave this for a later PR in which we execute a plan wholistically
Comment on lines
+53
to
+56
| const [undelegation] = await celestiaAccount.undelegate(delegations); | ||
|
|
||
| // wait for the undelegations to be complete (may take weeks) | ||
| await undelegation.completion; |
There was a problem hiding this comment.
👍 highlighting this change for other reviewers
| import type { TimestampRecord } from '@agoric/time'; | ||
| import type { ChainAddress } from './service.js'; | ||
|
|
||
| export type Delegation = { |
There was a problem hiding this comment.
Suggested change
| export type Delegation = { | |
| TODO import from `@agoric/cosmic-proto` instead of reimplementing | |
| export type Delegation = { |
| /** | ||
| * Register a hook to intercept an incoming IBC Transfer and handle it. | ||
| * Calling without arguments will unregister the hook. | ||
| */ |
There was a problem hiding this comment.
Suggested change
| */ | |
| TODO reference type from #8624 `packages/vats/src/localchain.js` | |
| */ |
| } | ||
|
|
||
| export interface Undelegation { | ||
| cancel: () => Promise<void>; |
There was a problem hiding this comment.
Suggested change
| cancel: () => Promise<void>; | |
| cancel: () => Promise<MsgCancelUnbondingDelegationResponse>; |
Would also need to add this type to delegation.d.ts:
type MsgCancelUnbondingDelegationResponse {}; This type/message does not appear in our current @agoric/cosmic-proto, and was seemingly released in cosmos-sdk v0.46.x
Comment on lines
266
to
278
| /** | ||
| * A LocalChain account that has the ability to intercept IBC Transfer | ||
| * packets and react to them. a.k.a. "IBC Hooks" | ||
| */ | ||
|
|
||
| export interface TransferAccount extends LocalChainAccount { | ||
| /** | ||
| * Register a hook to intercept an incoming IBC Transfer. | ||
| * Calling without arguments will unregister the hook | ||
| */ | ||
| interceptTransfer: (tap?: { upcall: (args: any) => Promise<any> }) => void; | ||
| } | ||
|
|
There was a problem hiding this comment.
Suggested change
| /** | |
| * A LocalChain account that has the ability to intercept IBC Transfer | |
| * packets and react to them. a.k.a. "IBC Hooks" | |
| */ | |
| export interface TransferAccount extends LocalChainAccount { | |
| /** | |
| * Register a hook to intercept an incoming IBC Transfer. | |
| * Calling without arguments will unregister the hook | |
| */ | |
| interceptTransfer: (tap?: { upcall: (args: any) => Promise<any> }) => void; | |
| } |
Please delete, this was removed in this commit in favor of exposing interceptTransfer under agoric on KnownChains
turadg
force-pushed
the
9207-orchestrator-stub
branch
from
ffb7bf0
to
1e054ac
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
step towards: #9207
Description
Adapt https://github.com/agoric-labs/orchestration-api-spec/ into agoric-sdk
Once approved, I'll clean up the commits.
Once landed, I'll archive the other repo, pointing people to
@agoric/orchestrationin this codebase.Security Considerations
Scaling Considerations
Documentation Considerations
Testing Considerations
Upgrade Considerations