Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: getBrandInfo() to support orcUtils.makeOsmosisSwap() (WIP) #9491

Closed
wants to merge 44 commits into from

Conversation

dckc
Copy link
Member

@dckc dckc commented Jun 12, 2024

refs:

Description

getBrandInfo() is synchronous in the Orchestrator API. This is a bunch of hack-and-slash to try to meet that constraint while I figure out whether it's negotiable (@dtribble ).

makeOsmosisSwap() is also sync and doesn't even take an Orchestrator arg. Before I even try to do that, I'd like to talk this over with @turadg and @0xpatrickdev

DRAFT until

  • various kludges

Security Considerations

Scaling Considerations

Documentation Considerations

Testing Considerations

Upgrade Considerations

Copy link

cloudflare-workers-and-pages bot commented Jun 12, 2024

Deploying agoric-sdk with  Cloudflare Pages  Cloudflare Pages

Latest commit: 98da85c
Status:🚫  Build failed.

View logs

@dckc
Copy link
Member Author

dckc commented Jul 16, 2024

@turadg a bunch of this has landed by way of other PRs, yes?

@mitdralla I'd still like to talk this over with you; was hoping to do it in person around Chain Abstraction Day but didn't manage.
cc @Jovonni

@turadg
Copy link
Member

turadg commented Jul 16, 2024

@turadg a bunch of this has landed by way of other PRs, yes?

Yep. At this point it might be better to use it to inform some fresh commits on top of master

@dckc
Copy link
Member Author

dckc commented Jul 29, 2024

obsolete. #9754 covers getBrandInfo().

makeOsmosisSwap() remains TODO.

@dckc
Copy link
Member Author

dckc commented Aug 30, 2024

for some follow-up, see:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants