fix(types): chain-info const #9496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-sdk with
|
| Latest commit: |
1daa3e2
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://806d9e14.agoric-sdk.pages.dev |
| Branch Preview URL: | https://ta-ibc-templates.agoric-sdk.pages.dev |
0xpatrickdev
approved these changes
Jun 12, 2024
When we started fetching the data by JSON, the import of JSON lost the string values, widening to `string`. This made the string templates fail. It also widened true and false to `boolean`, which would prevent the feature inference for what a Chain can do. This wraps in `const` so the actual values propagate in the type.
|
I don't see Umee / UX Chain. Not even in the fetched chain info. odd. When I add |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #9063
Description
When we started fetching the data by JSON, the import of JSON lost the string values, widening to
string. This made the string templates fail. It also widened true and false toboolean, which would prevent the feature inference for what a Chain can do.This wraps in
constso the actual values propagate in the type.Security Considerations
none
Scaling Considerations
none
Documentation Considerations
none
Testing Considerations
CI
Upgrade Considerations
none